[issue25381] Doc: Use of old description of raise in Python3

[Terry J. Reedy]

Change by Terry J. Reedy :


--
keywords: +patch
pull_requests: +25419
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/26838

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25381] Doc: Use of old description of raise in Python3

[Irit Katriel]

Irit Katriel  added the comment:

Yes, I thought since we need a PR the keyword was wrong. Thanks for the 
correction.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25381] Doc: Use of old description of raise in Python3

[Terry J. Reedy]

Terry J. Reedy  added the comment:

On 2007 Aug 15, extending.rst was merged into master (early 2.6 alpha)  and 
early 3.0 alpha.  The only change to this paragraph since the initial 2.6 
version was Serhiy changing "*NULL*" to "``NULL``" in 3.x on 2019 Oct 30.  I 
will post a PR with what I think is true now.

--
nosy: +iritkatriel
versions: +Python 3.10, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25381] Doc: Use of old description of raise in Python3

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Irit, it is unclear why you unchecked 'patch'.  Because no PR? The keyword  
includes a patch file attached to an issue.  Someone can convert it to a PR.  
From the tracker doc:
"patch There is a patch or pull request attached to the issue."

Because the 2nd patch was, in essence rejected as is?  A different matter, 
though most .patch or .diff files attached need revision when made a PR.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25381] Doc: Use of old description of raise in Python3

[Irit Katriel]

Change by Irit Katriel :


--
keywords:  -patch
versions: +Python 3.11 -Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25381] Doc: Use of old description of raise in Python3

[Ezio Melotti]

Changes by Ezio Melotti :


--
nosy: +ezio.melotti
type:  -> enhancement
versions:  -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25381] Doc: Use of old description of raise in Python3

[John Mark Vandenberg]

Changes by John Mark Vandenberg :


--
nosy: +jayvdb

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25381] Doc: Use of old description of raise in Python3

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25381] Doc: Use of old description of raise in Python3

[R. David Murray]

R. David Murray added the comment:

There's also the fact that the argument to raise can be an exception class, but 
the second element of sys.exc_info is still an instance of that class, which 
only occurred to me while reading your revised patch.

--
stage: patch review -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25381] Doc: Use of old description of raise in Python3

[Xiang Zhang]

Xiang Zhang added the comment:

Actually what I intend is that the exception object passed to raise is the 
exception instance raise finally throws (what is stored in the second 
variable). So it seems wise not to do any more for me. A single sentence has 
lead to confusion, not to mention more.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25381] Doc: Use of old description of raise in Python3

[R. David Murray]

Changes by R. David Murray :


--
stage: commit review -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25381] Doc: Use of old description of raise in Python3

[Xiang Zhang]

Xiang Zhang added the comment:

With this sentence

A second global variable stores the “associated value” of the exception (the 
second argument to raise).

I think the phrase inside the parentheses is to explain the "associated value", 
which is usually a string passed to the exception object, not the exception 
object itself.

Do I misunderstand anything?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25381] Doc: Use of old description of raise in Python3

[R. David Murray]

R. David Murray added the comment:

Yes.  The second element of the sys.exc_info result is the exception instance, 
not the argument to the exception constructor.  The old raise syntax allowed 
you to specify the exception instance as the second argument to raise, but if 
you specified a string it converted it to an exception instance using the first 
argument as the constructor to call.  So, the 2.7 docs aren't entirely 
accurate, since it isn't the second argument to raise that is stored, but the 
object that results from raise *processing* its second argument.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25381] Doc: Use of old description of raise in Python3

[R. David Murray]

R. David Murray added the comment:

Actually, I take that back.  Shouldn't it be "the object passed *as* the 
exception object to raise?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25381] Doc: Use of old description of raise in Python3

[Xiang Zhang]

Xiang Zhang added the comment:

Oops, I misunderstand sys.exc_info all the time, sad :(

Now, both versions of doc are not correct. Please make them fixed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25381] Doc: Use of old description of raise in Python3

[R. David Murray]

R. David Murray added the comment:

Looks good to me.

--
nosy: +r.david.murray
stage:  -> commit review
title: Doc: Use old description of raise in Python3 -> Doc: Use of old 
description of raise in Python3
versions: +Python 3.4, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25381] Doc: Use of old description of raise in Python3

[Xiang Zhang]

Xiang Zhang added the comment:

I fix my patch with David's comment.

--
Added file: http://bugs.python.org/file40766/doc_extending2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25381] Doc: Use of old description of raise in Python3

[Xiang Zhang]

Xiang Zhang added the comment:

Yes, you are right martin. It seems the whole chapter needs more updates, not 
only the bits I mentioned. I won't provide a new patch since I am not an 
English native and I am not sure I can provide an accurate and right 
description. Hope someone else may help.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com