[issue25387] sound_msgbeep doesn't check the return value of MessageBeep

[Zachary Ware]

Zachary Ware added the comment:

I decided not to backport.  If anyone else would like to, I won't stand in 
their way.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 2.7, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25387] sound_msgbeep doesn't check the return value of MessageBeep

[Roundup Robot]

Roundup Robot added the comment:

New changeset 4e5b3dc049cc by Zachary Ware in branch 'default':
Issue #25387: Check return value of winsound.MessageBeep
https://hg.python.org/cpython/rev/4e5b3dc049cc

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25387] sound_msgbeep doesn't check the return value of MessageBeep

[Zachary Ware]

Zachary Ware added the comment:

Here's a patch.  This has the possibility of breaking existing code, but the 
fix is simple (just catch RuntimeError) and is probably more in line with 
what's expected.

--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file44106/check_msgbeep_error.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25387] sound_msgbeep doesn't check the return value of MessageBeep

[Zachary Ware]

Zachary Ware added the comment:

Though the source link is incredibly out of date (we've been on hg.python.org 
for about 5 years now, and are soon to move to Github), this is a current 
issue.  The suggested 'example "fix"' is not applicable, though; in that case, 
MessageBeep is just used in preference to Beep, and falls back to Beep if 
MessageBeep fails.

--
stage:  -> needs patch
versions: +Python 2.7, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25387] sound_msgbeep doesn't check the return value of MessageBeep

[Alexander Riccio]

New submission from Alexander Riccio:

A really minor issue (probably qualifies for the "easy" keyword):

sound_msgbeep (in http://svn.python.org/projects/python/trunk/PC/winsound.c) 
doesn't check the return value of MessageBeep 
(https://msdn.microsoft.com/en-us/library/windows/desktop/ms680356.aspx). This 
is a very minor issue, but the possibility of failure is not mentioned in the 
winsound documentation. Invisible failures are quite surprising.


A message in the Gnome archives 
(https://mail.gnome.org/archives/commits-list/2010-November/msg01938.html) has 
an example "fix".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25387] sound_msgbeep doesn't check the return value of MessageBeep

[Alexander Riccio]

Changes by Alexander Riccio :


--
components: Windows
nosy: Alexander Riccio, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: sound_msgbeep doesn't check the return value of MessageBeep
type: behavior
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com