[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

[Miko Ohtamaa]

Miko Ohtamaa added the comment:

I think there is something more in this. 

I am running Python 3.5.0 (default, Apr 24 2016, 12:47:36).

Sparkpost servers require AUTH LOGIN approach as per their instructions 
https://support.sparkpost.com/customer/portal/articles/1988470-smtp-connection-problems

When trying to use these (free) servers smtplib authentication will result to 
smtplib.SMTPAuthenticationError: (500, b'5.5.2 unrecognized command') like in 
the issue description earlier. I am still investigating this.

--
nosy: +miohtama, ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

[Roundup Robot]

Roundup Robot added the comment:

New changeset d13263ecf0c6 by R David Murray in branch '3.5':
#25446: Fix regression in smtplib's AUTH LOGIN support.
https://hg.python.org/cpython/rev/d13263ecf0c6

New changeset 7368b86432c6 by R David Murray in branch 'default':
Merge: #25446: Fix regression in smtplib's AUTH LOGIN support.
https://hg.python.org/cpython/rev/7368b86432c6

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

[R. David Murray]

R. David Murray added the comment:

Fixed.  I figured it was better not to wait for a review in this case...the fix 
is straightforward, but writing the test took quite a bit of work.  The auth 
tests in smtplib are now much more robust, thanks in large part to Milan's code 
in issue 21935.

--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

[Larry Hastings]

Larry Hastings added the comment:

Okay, I'm scheduling 3.5.1rc1 on the assumption that you'll check in by next 
weekend.  If you're going to slip please let me know and I'll slip accordingly.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

[Larry Hastings]

Larry Hastings added the comment:

I think it's about time to think about releasing 3.5.1.  But since this bug is 
marked as a "release blocker", 3.5.1 cannot be released until this is fixed.  
Arguably I can't even really make a schedule for 3.5.1 until it's fixed, or at 
least I'm reasonably confident I know when it'll be fixed.

Any idea when this might be fixed?

--
nosy: +larry

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

[R. David Murray]

R. David Murray added the comment:

I will work on it this week, should have something committed before the end of 
next weekend.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

[Chris Angelico]

Changes by Chris Angelico :


--
nosy: +Rosuav

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

[R. David Murray]

R. David Murray added the comment:

Thanks, but special-casing login in the 'auth' method means that the auth 
method isn't working right, since special-casing defeats the whole purpose of 
the auth mechanism.

I think we need to change the logic in auth so that it is checking for a 334 
even if it has been provided an initial response.  That is, outdent the block 
that starts with the '# Server replies...' comment.  Once that is done, 
auth_login becomes:

  def auth_login(self, challenge=None)
  if challenge is None:
  return encode_base64(self.user.encode('ascii'))
  else:
  return self.password

We may also need to add a try/except around the base64.decodebytes in auth.

And we need a unit test that demonstrates the current failure.

I'm also wondering now about the ascii encoding on the challenge and response.  
Someone should check the RFC to see if those are limited to ascii or if they 
can contain other bytes.  If they are limited to ascii we should stick in a 
comment to that effect with a pointer to the relevant RFC section.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

[R. David Murray]

R. David Murray added the comment:

Can you explain more about the failure you are seeing?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

[R. David Murray]

R. David Murray added the comment:

Sorry, I misremenbered and thought that fix didn't make it in to 3.5, but in 
fact you are talking about the behavior of that fix.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

[R. David Murray]

R. David Murray added the comment:

Does the fix at the end of issue 15014 address your concern?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

[Oliver Merkel]

New submission from Oliver Merkel:

class SMTP:
def auth_login(self, challenge=None):

The self.docmd should use cmd "AUTH" with parameter "LOGIN" + encoded login like

(code, resp) = self.docmd("AUTH", "LOGIN " +
encode_base64(self.user.encode('ascii'), eol=''))

with

def auth(self, mechanism, authobject, *, initial_response_ok=True):

that should not send a "AUTH" in self.docmd in case the mechanism is 'LOGIN' and

if initial_response is not None:

meaning

if mechanism == 'LOGIN':
(code, resp) = self.docmd(response)
else:
(code, resp) = self.docmd("AUTH", mechanism + " " + response)

---

Could someone kindly review, evtly come up with better suggestion?

In short:
$ diff /c/Python35/Lib/smtplib-old.py /c/Python35/Lib/smtplib.py
630c630,633
< (code, resp) = self.docmd("AUTH", mechanism + " " + response)
---
> if mechanism == 'LOGIN':
> (code, resp) = self.docmd(response)
> else:
> (code, resp) = self.docmd("AUTH", mechanism + " " + response)
660c663
< (code, resp) = self.docmd(
---
> (code, resp) = self.docmd("AUTH", "LOGIN " +

--
components: email
messages: 253225
nosy: barry, merkel, r.david.murray
priority: normal
severity: normal
status: open
title: smtplib.py AUTH LOGIN code messed up sending login and password data 
since 3.5
type: behavior
versions: Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

[Oliver Merkel]

Oliver Merkel added the comment:

Sample session log output showing the error with smtp.set_debuglevel(1):

send: 'ehlo \r\n'
reply: b'250- Hello [myIP4address]\r\n'
reply: b'250-SIZE 53248000\r\n'
reply: b'250-PIPELINING\r\n'
reply: b'250-DSN\r\n'
reply: b'250-ENHANCEDSTATUSCODES\r\n'
reply: b'250-STARTTLS\r\n'
reply: b'250-AUTH GSSAPI NTLM\r\n'
reply: b'250-8BITMIME\r\n'
reply: b'250-BINARYMIME\r\n'
reply: b'250 CHUNKING\r\n'
reply: retcode (250); Msg: b' Hello [myIP4address]\
nSIZE 53248000\nPIPELINING\nDSN\nENHANCEDSTATUSCODES\nSTARTTLS\nAUTH GSSAPI NTLM
\n8BITMIME\nBINARYMIME\nCHUNKING'
send: 'STARTTLS\r\n'
reply: b'220 2.0.0 SMTP server ready\r\n'
reply: retcode (220); Msg: b'2.0.0 SMTP server ready'
send: 'ehlo [mymachinename]\r\n'
reply: b'250- Hello [myIP4address]\r\n'
reply: b'250-SIZE 53248000\r\n'
reply: b'250-PIPELINING\r\n'
reply: b'250-DSN\r\n'
reply: b'250-ENHANCEDSTATUSCODES\r\n'
reply: b'250-AUTH GSSAPI NTLM LOGIN\r\n'
reply: b'250-8BITMIME\r\n'
reply: b'250-BINARYMIME\r\n'
reply: b'250 CHUNKING\r\n'
reply: retcode (250); Msg: b' Hello [myIP4address]\
nSIZE 53248000\nPIPELINING\nDSN\nENHANCEDSTATUSCODES\nAUTH GSSAPI NTLM LOGIN\n8B
ITMIME\nBINARYMIME\nCHUNKING'
send: '==\r\n'
reply: b'500 5.3.3 Unrecognized command\r\n'
reply: retcode (500); Msg: b'5.3.3 Unrecognized command'
send: 'QUIT\r\n'
reply: b'221 2.0.0 Service closing transmission channel\r\n'
reply: retcode (221); Msg: b'2.0.0 Service closing transmission channel'
Traceback (most recent call last):
  File "sendtestmail.py", line 172, in 
announcement.sendMail(password)
  File "sendtestmail.py", line 97, in sendMail
smtp.login( self.getShortAddressList()[0], password )
  File "c:\Python35\lib\smtplib.py", line 730, in login
raise last_exception
  File "c:\Python35\lib\smtplib.py", line 721, in login
initial_response_ok=initial_response_ok)
  File "c:\Python35\lib\smtplib.py", line 627, in auth
initial_response = (authobject() if initial_response_ok else None)
  File "c:\Python35\lib\smtplib.py", line 664, in auth_login
raise SMTPAuthenticationError(code, resp)
smtplib.SMTPAuthenticationError: (500, b'5.3.3 Unrecognized command')

due to missing AUTH LOGIN here as previously described...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

[Oliver Merkel]

Oliver Merkel added the comment:

Let us assume you want to establish a smtp session with AUTH LOGIN as the 
supported authentication type. Sample code to send mail: Typical preparation 
steps like

with SMTP( mailserver, 587 ) as smtp:
  # smtp.set_debuglevel(1)
  smtp.ehlo()
  smtp.starttls()
  smtp.ehlo()
  smtp.login( account, password )

If you try to login (last line in sample code above) at the smtp server then 
the smtp server will expect a command to be send like

AUTH LOGIN 

Now switching from sample code to our smtplib.py:

Since the "AUTH LOGIN" is missing in original Python35/Lib/smtplib.py in line...

660c663
< (code, resp) = self.docmd(
---
> (code, resp) = self.docmd("AUTH", "LOGIN " +

... the smtp server will answer that the library is sending an unknown command 
here. That is why I added... "AUTH", "LOGIN " + ...at this line.

Line 660 in class SMTP: def auth_login is called before it reaches line 630 in 
class SMTP: def auth

In case of authentication type AUTH LOGIN in line 630 you must not call with 
"AUTH", mechanism + " " +

So the following changes have to be applied at least for AUTH LOGIN mechanism

630c630,633
< (code, resp) = self.docmd("AUTH", mechanism + " " + response)
---
> if mechanism == 'LOGIN':
> (code, resp) = self.docmd(response)
> else:
> (code, resp) = self.docmd("AUTH", mechanism + " " + response)

The first change affecting line 660 described above will will imply that the 
you remove the AUTH mechanism in line 630. For mechanism LOGIN the base64 
encoded password will be needed to be sent in 660...

See possible fix in the diff above.

To ease understanding the fix I will apply a running version of my local 
Lib/smtplib.py (instead of just providing the diff lines). Feel free to 
directly use the file.

--
Added file: http://bugs.python.org/file40828/smtplib.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

[R. David Murray]

R. David Murray added the comment:

Ah, now I see what you are saying.  How in the world did we miss that?  Our 
unit tests must be broken too.

--
keywords: +3.5regression
priority: normal -> release blocker
stage:  -> needs patch
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25446] smtplib.py AUTH LOGIN code messed up sending login and password data since 3.5

[Oliver Merkel]

Oliver Merkel added the comment:

Change proposal attached as a unified diff / patch file.

--
keywords: +patch
Added file: http://bugs.python.org/file40829/smtplib-patch.issue25446.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com