[issue25462] Avoid repeated hash calculation in C implementation of OrderedDict

[Roundup Robot]

Roundup Robot added the comment:

New changeset 52ff0c00a404 by Serhiy Storchaka in branch '3.5':
Issue #25462: The hash of the key now is calculated only once in most
https://hg.python.org/cpython/rev/52ff0c00a404

New changeset 828c9b920532 by Serhiy Storchaka in branch 'default':
Issue #25462: The hash of the key now is calculated only once in most
https://hg.python.org/cpython/rev/828c9b920532

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25462] Avoid repeated hash calculation in C implementation of OrderedDict

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
stage: commit review -> resolved

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25462] Avoid repeated hash calculation in C implementation of OrderedDict

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you Raymond and Eric.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25462] Avoid repeated hash calculation in C implementation of OrderedDict

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25462] Avoid repeated hash calculation in C implementation of OrderedDict

[Raymond Hettinger]

Raymond Hettinger added the comment:

The patch looks correct, and it improves the integrity of the C implementation.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25462] Avoid repeated hash calculation in C implementation of OrderedDict

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Could you please make a review of this patch Eric? It is moved to separate 
issue because it is enough large and complex.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25462] Avoid repeated hash calculation in C implementation of OrderedDict

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


Added file: http://bugs.python.org/file40960/odict_knownhash_2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25462] Avoid repeated hash calculation in C implementation of OrderedDict

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

There are private _PyDict_*_KnownHash functions that allow to avoid repeated 
hash calculation in complex operations with a dict. Proposed patch makes C 
implementation of OrderedDict to use these functions. It is not just an 
optimization, it makes some OrderedDict methods atomic (or almost atomic), that 
decreases a chance to desynchronize the linked list with the dict. That is why 
I suggest to commit the patch in 3.5.

--
components: Regular Expressions
files: odict_knownhash.patch
keywords: patch
messages: 253343
nosy: eric.snow, ezio.melotti, mrabarnett, rhettinger, serhiy.storchaka
priority: normal
severity: normal
stage: patch review
status: open
title: Avoid repeated hash calculation in C implementation of OrderedDict
type: enhancement
versions: Python 3.5, Python 3.6
Added file: http://bugs.python.org/file40838/odict_knownhash.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com