[issue25522] IDLE: warn if save-as name matches stdlib name

[Zackery Spytz]

Zackery Spytz  added the comment:

I have created a pull request for this issue.

--
nosy: +ZackerySpytz

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25522] IDLE: warn if save-as name matches stdlib name

[Zackery Spytz]

Change by Zackery Spytz :


--
keywords: +patch
pull_requests: +16565
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/17051

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25522] IDLE: warn if save-as name matches stdlib name

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Beginners import stdlib files such as random.  And they save scripts with such 
name, and accidentally import the script when not desired.

Beginners should learn how to test a script by running a test file provided by 
an instructor or written themselves.  In either case, they *will* have to 
import the script.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25522] IDLE: warn if save-as name matches stdlib name

[Vedran Čačić]

Vedran Čačić  added the comment:

Many beginners don't write files in order to import them. For them, these 
name-checking is simply adding noise. If you want to do something in this area, 
I think a much more useful (and difficult) course of action would be to check 
on the opposite end. If an AttributeError "module blah has no attribute foo" is 
raised, then check whether a file in the current directory (or simply the 
current file) is named blah, and there is also a stdlib blah that has fool.

--
nosy: +veky

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25522] IDLE: warn if save-as name matches stdlib name

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Also check if the name is not an identifier and therefore could not be 
imported.  Example:

>>> exec('import abc--bb')
import abc--bb
  ^
SyntaxError: invalid syntax

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25522] IDLE: warn if save-as name matches stdlib name

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
assignee:  -> terry.reedy
components: +IDLE
versions: +Python 3.7 -Python 2.7, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25522] IDLE: warn if save-as name matches stdlib name

[irdb]

Changes by irdb :


--
nosy: +irdb

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25522] IDLE: warn if save-as name matches stdlib name

[Laura Creighton]

Laura Creighton added the comment:

Do we need a full path name here as well?  Probably not.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25522] IDLE: warn if save-as name matches stdlib name

[Laura Creighton]

Laura Creighton added the comment:

I'm not sure about "Neither you nor Python will be able to import 
the stdlib."  Depending on what the file is, you may be able to import
it later.  I'd prefer:

"If you run Python in this directory, your version of 
will be used instead of the one in the standard library.  This may cause Idle 
to behave strangely, or possibly not run at all."

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25522] IDLE: warn if save-as name matches stdlib name

[Terry J. Reedy]

Terry J. Reedy added the comment:

The lib messages should say "Neither you nor python will be able to import the 
stdlib module".  Example of python-imported lib names that a beginner might 
write are abc, io, os, nt, and stat.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25522] IDLE: warn if save-as name matches stdlib name

[Terry J. Reedy]

New submission from Terry J. Reedy:

When users 'saveas', warn if name matches that of a stdlib modules. Note that 
shadowing is opposite for lib and binary (builtin) modules, so message needs to 
be different.  I am not worrying about 3rd party modules on the search path 
(ie, site-packages), which would be shadowed like lib modules. Rough outline of 
code to add to IOBinding.

from os,path import dirname
import sys

# this part on initiallzation or first saveas call
def libmodules():
with open(dirname(dirname(__file__))) as lib:
for f in lib:
if  or f.endswith(.py):
yield f
# test.test__all__ has this code

islibmodule = frozenset(libmodules()).__contains__
isbinmodule = frozenset(sys.builtin_module_names).__contains__

# this part after saveas dialog returns
if islibmodule(name):
go = warn("This name matches a stdlib name in /Lib. If you run python in 
this directory, you will not be able to import the stdlib module.  Continue?".)
elif isbinmodule(name):
go = warn("This name matches a builtin stdlib name.  You will not be able 
to import this file.  Continue?".)
else:
go = True
if go:

else:
   (get name again>  # or put in while not go loop

--
messages: 253775
nosy: lac, markroseman, terry.reedy
priority: normal
severity: normal
stage: needs patch
status: open
title: IDLE: warn if save-as name matches stdlib name
type: enhancement
versions: Python 2.7, Python 3.4, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com