[issue25528] Attempt to further increase test coverage of calendar module

[Irit Katriel]

Irit Katriel  added the comment:

The patch needs to be reviewed. If the tests are still relevant and increase 
coverage, it needs to be converted to a GitHub PR. Otherwise this issue can be 
closed.


See also issue13330.

--
nosy: +iritkatriel

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25528] Attempt to further increase test coverage of calendar module

[Stéphane Wirtel]

Stéphane Wirtel added the comment:

no problem about the second patch of Rohit.

pass the test with default and I have tested the code in the REPL.

--
nosy: +matrixise

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25528] Attempt to further increase test coverage of calendar module

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

The problem with Rohit's patch is that it throws out existing test case.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25528] Attempt to further increase test coverage of calendar module

[Stéphane Wirtel]

Stéphane Wirtel added the comment:

Sure,

But the patch is correct.

Now, you are right, we have to ask him a new patch where the function is really 
tested.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25528] Attempt to further increase test coverage of calendar module

[Rohit Mediratta]

Rohit Mediratta added the comment:

Thanks for the comments. I did indeed have the patch reversed. I've resolved it 
here.

Martin: I had the locale=None case in the patch.

--
Added file: http://bugs.python.org/file41109/mywork_update.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25528] Attempt to further increase test coverage of calendar module

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25528] Attempt to further increase test coverage of calendar module

[Rohit Mediratta]

New submission from Rohit Mediratta:

Opened to submit a patch.

- make patchcheck succeeded
- full testsuite succeeded
- Old coverage 
   Lib/calendar.py 375 5486%   511, 519, 541, 608-699, 703
- New coverage
   Lib/calendar.py 375 5186%   608-699, 703

--
components: Tests
files: mywork.patch
keywords: patch
messages: 253836
nosy: Rohit Mediratta
priority: normal
severity: normal
status: open
title: Attempt to further increase test coverage of calendar module
type: enhancement
versions: Python 3.6
Added file: http://bugs.python.org/file40916/mywork.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com