[issue25544] cleanup temporary files in distutils.has_function

[Steve Dower]

Steve Dower  added the comment:

Distutils is now deprecated (see PEP 632) and all tagged issues are being 
closed. From now until removal, only release blocking issues will be considered 
for distutils.

If this issue does not relate to distutils, please remove the component and 
reopen it. If you believe it still requires a fix, most likely the issue should 
be re-reported at https://github.com/pypa/setuptools

--
nosy: +steve.dower
resolution:  -> out of date
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25544] cleanup temporary files in distutils.has_function

[SilentGhost]

SilentGhost added the comment:

Here is the review-able patch.

--
Added file: http://bugs.python.org/file42400/minrk_issue25544.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25544] cleanup temporary files in distutils.has_function

[Min RK]

Min RK added the comment:

update patch to use file context manager on temporary source file

it should apply cleanly on current default (778ccbe3cf74)

--
Added file: 
http://bugs.python.org/file42399/0001-cleanup-tempfiles-in-has_function.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25544] cleanup temporary files in distutils.has_function

[Min RK]

Min RK added the comment:

Absolutely, I'll try to do that tomorrow.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25544] cleanup temporary files in distutils.has_function

[SilentGhost]

SilentGhost added the comment:

Hi Min RK, could you please update your patch so that it would cleanly apply to 
the tip of default branch. Also since you're re-writing a big chunk of that 
function, could I ask you to use with context manager for the temporary source 
file.

--
nosy: +SilentGhost
stage:  -> needs patch
versions:  -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25544] cleanup temporary files in distutils.has_function

[Min RK]

New submission from Min RK:

One of the nits noted in http://bugs.python.org/issue717152, which introduced 
ccompiler.has_function, was that it does not clean up after itself.

This patch uses a TemporaryDirectory context to ensure that the files created 
during has_function are cleaned up.

--
components: Distutils
files: 0001-cleanup-temporary-files-in-ccompiler.has_function.patch
keywords: patch
messages: 253993
nosy: dstufft, eric.araujo, minrk
priority: normal
severity: normal
status: open
title: cleanup temporary files in distutils.has_function
type: enhancement
versions: Python 3.4, Python 3.5, Python 3.6
Added file: 
http://bugs.python.org/file40933/0001-cleanup-temporary-files-in-ccompiler.has_function.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com