[issue25573] FrameSummary repr() does not support previously working uses of repr in traceback module

[Irit Katriel]

Change by Irit Katriel :


--
pull_requests:  -22554

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25573] FrameSummary repr() does not support previously working uses of repr in traceback module

[Irit Katriel]

Change by Irit Katriel :


--
pull_requests:  -22553

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25573] FrameSummary repr() does not support previously working uses of repr in traceback module

[Irit Katriel]

Change by Irit Katriel :


--
pull_requests: +22554
pull_request: https://github.com/python/cpython/pull/23688

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25573] FrameSummary repr() does not support previously working uses of repr in traceback module

[Irit Katriel]

Change by Irit Katriel :


--
pull_requests: +22553
pull_request: https://github.com/python/cpython/pull/23687

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25573] FrameSummary repr() does not support previously working uses of repr in traceback module

[Irit Katriel]

Change by Irit Katriel :


--
pull_requests:  -22551

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25573] FrameSummary repr() does not support previously working uses of repr in traceback module

[Irit Katriel]

Change by Irit Katriel :


--
keywords: +patch
pull_requests: +22551
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/23687

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25573] FrameSummary repr() does not support previously working uses of repr in traceback module

[Irit Katriel]

Irit Katriel  added the comment:

I think the fourth element (the code line) was omitted from repr because it is 
not one of the constructor args for FrameSummary (it is derived from them), so 
it's redundant in terms of describing this instance.

--
nosy: +iritkatriel
versions: +Python 3.10, Python 3.8, Python 3.9 -Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25573] FrameSummary repr() does not support previously working uses of repr in traceback module

[Berker Peksag]

Change by Berker Peksag :


--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25573] FrameSummary repr() does not support previously working uses of repr in traceback module

[Robert Collins]

Robert Collins added the comment:

So I think its fine to have a __len__ reporting 4. tuple(..) works via the 
iter() call, but thats really just a thunk to keep existing code working, and 
so __len__ for the same reason makes sense.

On the documentation issue, yes, updating the docs is appropriate.

Having the repr produce all the elements would be ok, the reason it is lazy is 
to avoid high costs for transient FrameSummary when its created and discarded 
shortly after.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25573] FrameSummary repr() does not support previously working uses of repr in traceback module

[R. David Murray]

R. David Murray added the comment:

I take it back.  Since tuple(framesummary) produces all four elements, I think 
the repr should too.  Likewise, in the __len__ issue I think it should always 
report 4.

Let see if other devs agree.

--
resolution: fixed -> 
stage: resolved -> needs patch
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25573] FrameSummary repr() does not support previously working uses of repr in traceback module

[R. David Murray]

R. David Murray added the comment:

Ah, I see there is.  It is read lazily.  It is an interesting question whether 
it should be read when the repr is printed...let's say no until/unless someone 
comes up with a good reason why it would be worthwhile.

--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25573] FrameSummary repr() does not support previously working uses of repr in traceback module

[R. David Murray]

R. David Murray added the comment:

Is there a reason the fourth element of the tuple is not included in the 
FrameSummary repr?  Otherwise I agree that this could be closed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25573] FrameSummary repr() does not support previously working uses of repr in traceback module

[Tomas Orsava]

Tomas Orsava added the comment:

This problem has already been addressed in issue 27208, and it was fixed by 
updating the documentation to reflect the new repr().

Therefore, I believe this issue can be closed.

--
nosy: +torsava

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25573] FrameSummary repr() does not support previously working uses of repr in traceback module

[Stéphane Wirtel]

Stéphane Wirtel added the comment:

Could you check with Python 3.4 ?

--
nosy: +matrixise

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25573] FrameSummary repr() does not support previously working uses of repr in traceback module

[R. David Murray]

R. David Murray added the comment:

IMO, that is neither a lie nor a doc bug, it is a bug in the new traceback 
features that were added in 3.5.

--
assignee: docs@python -> 
keywords: +3.5regression
nosy: +r.david.murray, rbcollins
stage:  -> needs patch
title: traceback documentation example is lying about FrameSummary repr() -> 
FrameSummary repr() does not support previously working uses of repr in 
traceback module

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25573] FrameSummary repr() does not support previously working uses of repr in traceback module

[Stéphane Wirtel]

Stéphane Wirtel added the comment:

Oops, sorry,

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com