[issue25608] ascynio readexactly() should raise ValueError if passed length <= 0 in argument

[Yury Selivanov]

Yury Selivanov added the comment:

This issue is now resolved (see https://github.com/python/asyncio/pull/298)

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25608] ascynio readexactly() should raise ValueError if passed length <= 0 in argument

[Марк Коренберг]

Марк Коренберг added the comment:

Okay, https://github.com/python/asyncio/pull/298 is ready

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25608] ascynio readexactly() should raise ValueError if passed length <= 0 in argument

[Guido van Rossum]

Guido van Rossum added the comment:

read(0) on a regular stream and os.read(fd, 0) also return an empty string 
without error. This is not something we should keep debating.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25608] ascynio readexactly() should raise ValueError if passed length <= 0 in argument

[Марк Коренберг]

Марк Коренберг added the comment:

result of readexactly(0) is indistinguishable from EOF, so no one should try to 
use that as I think.

What is the useful case when zero bytes should be read ?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25608] ascynio readexactly() should raise ValueError if passed length <= 0 in argument

[Guido van Rossum]

Guido van Rossum added the comment:

I'm okay with raising ValueError for length<0; but for length==0 the
behavior is very much intentional -- reading zero bytes is sometimes a
useful end case that otherwise you would have to work around in the
caller.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25608] ascynio readexactly() should raise ValueError if passed length <= 0 in argument

[Марк Коренберг]

New submission from Марк Коренберг:

ascynio readexactly() should raise ValueError if passed length <= 0 in argument.

Now, it return empty string, which is just error hiding. Why not to raise 
ValueError ? 

Returning empty string is error prone. This behaviour was not changed since 
initial commit of asyncio, so probably was not done intentionally.

--
components: asyncio
messages: 254545
nosy: gvanrossum, haypo, mmarkk, yselivanov
priority: normal
severity: normal
status: open
title: ascynio readexactly() should raise ValueError if passed length <= 0 in 
argument
type: behavior
versions: Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com