[issue25729] update pure python datetime.timedelta creation

[Paul Ganssle]

Change by Paul Ganssle :


--
nosy: +p-ganssle

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25729] update pure python datetime.timedelta creation

[Alexander Belopolsky]

Alexander Belopolsky  added the comment:

Brian, is this still relevant?  If so, cab you submit a pull request?

--
versions: +Python 3.7 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25729] update pure python datetime.timedelta creation

[Alexander Belopolsky]

Alexander Belopolsky added the comment:

For future reference, here is a link to PyPy history of datetime.py:

https://bitbucket.org/pypy/pypy/history-node/919e00b3e558/lib_pypy/datetime.py?at=default

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25729] update pure python datetime.timedelta creation

[Alexander Belopolsky]

Alexander Belopolsky added the comment:

Brian, we had a similar discussion in issue 20858, but I am still unsure about 
the relationship between our datetime.py and that in PyPy.  Do you use CPython 
version in PyPy?  If not, have you applied this patch and if so, can you link 
to a PyPy issue or a commit?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25729] update pure python datetime.timedelta creation

[Alexander Belopolsky]

Changes by Alexander Belopolsky :


--
assignee:  -> belopolsky
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25729] update pure python datetime.timedelta creation

[Brian Kearns]

Brian Kearns added the comment:

Bug fixes are to the test suite itself, and the name cleanup, minor. Best 
classified as enhancement, apply where applicable.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25729] update pure python datetime.timedelta creation

[Brian Kearns]

Brian Kearns added the comment:

Updated again

--
Added file: http://bugs.python.org/file41165/timedelta3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25729] update pure python datetime.timedelta creation

[Brian Kearns]

Brian Kearns added the comment:

Updated patch per review

--
Added file: http://bugs.python.org/file41164/timedelta2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25729] update pure python datetime.timedelta creation

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Looks you are missed Victor's and my comments.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25729] update pure python datetime.timedelta creation

[Brian Kearns]

Changes by Brian Kearns :


Removed file: http://bugs.python.org/file41158/timedelta.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25729] update pure python datetime.timedelta creation

[Brian Kearns]

Changes by Brian Kearns :


Added file: http://bugs.python.org/file41159/timedelta.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25729] update pure python datetime.timedelta creation

[Brian Kearns]

New submission from Brian Kearns:

Brings timedelta creation up to par with the (simpler) C equivalent. Gives a 
nice speed boost on the pure-py version (not worth much on CPython but useful 
on other implementations like PyPy).

Included in a few other small bug fixes/cleanups, should be self-explanatory.

--
files: timedelta.patch
keywords: patch
messages: 255322
nosy: bdkearns
priority: normal
severity: normal
status: open
title: update pure python datetime.timedelta creation
versions: Python 3.4, Python 3.5, Python 3.6
Added file: http://bugs.python.org/file41158/timedelta.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com