[issue25740] multiple issues in http.client

2015-11-26 Thread Martin Panter

Martin Panter added the comment:

I missed seeing the _get_hostport() change in the commit. So you are saying 
that values out of range 1–65535 should raise InvalidURL("nonnumeric port . . 
."). The error message isn’t quite right.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25740] multiple issues in http.client

2015-11-26 Thread Martin Panter

Martin Panter added the comment:

Thanks for these fixes. It might be better to open other report(s) for the 
FIXME comments, so you can explain them better, and propose any ideas or 
possible solutions. For some of them, it may be more appropriate to just fix 
them in the next (3.6) release, such as the method case insensitivity thing (to 
minimize backwards compatibility problems).

It would be good to have regression test cases for each bug fixed.

Regarding folded header field values, I think there was some discussion about 
deprecating that ability in Issue 22928. Definitely needs a separate report.

See Issue 23740 about various quirks with what objects and automatic encodings 
are accepted when sending a request. It is already a can of worms; I suggest 
not to make it any more complicated.

Can you elaborate on accepting invalid ports? Is this related to Issue 24169?

--
nosy: +martin.panter
stage:  -> patch review
type:  -> behavior
versions: +Python 2.7, Python 3.4, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25740] multiple issues in http.client

2015-11-26 Thread SpaceOne

New submission from SpaceOne:

* RESET_CONTENT not evaluated
* negative chunk size accepted
* invalid ports accepted
* success status !== 200 ignored

Patch: 
https://github.com/spaceone/cpython/commit/3289080306408db971f8b816d3e9f0ab44ed392b

Part of github Pull Request https://github.com/python/cpython/pull/19 from 
July. Should I split this up into multiple bugtracker issues?

--
components: Library (Lib)
messages: 255445
nosy: spaceone
priority: normal
severity: normal
status: open
title: multiple issues in http.client

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com