[issue25809] "Invalid" tests on locales

[Roundup Robot]

Roundup Robot added the comment:

New changeset bb7a19e42566 by Martin Panter in branch '3.4':
Issue #25809: Skip testing platform-dependent French thousands separator
https://hg.python.org/cpython/rev/bb7a19e42566

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25809] "Invalid" tests on locales

[koobs]

koobs added the comment:

Thank you all. A+++, would collaborate again.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25809] "Invalid" tests on locales

[Martin Panter]

Martin Panter added the comment:

3.4 buildbot is fixed now

--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25809] "Invalid" tests on locales

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thanks Martin.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25809] "Invalid" tests on locales

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Just commit to 3.4, merge forward, and push. I don't think there is need to 
pick up this in the final 3.4.4 release. But this can be picked up by 
maintainers of specific Linux distributions if new libc will come with the 
non-breaking space for French locale. Looks as there is a tendency to move from 
the space to the non-breaking space.

--
nosy: +larry

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25809] "Invalid" tests on locales

[koobs]

koobs added the comment:

Just to note, the koobs-freebsd-current buildbot is still failing on 3.4, which 
reminded me to re-open

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25809] "Invalid" tests on locales

[koobs]

koobs added the comment:

Re-open for 3.4 merge

--
status: closed -> open
versions: +Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25809] "Invalid" tests on locales

[Martin Panter]

Martin Panter added the comment:

The koobs-freebsd11 buildbots are starting to look greener now

--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25809] "Invalid" tests on locales

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you Martin.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25809] "Invalid" tests on locales

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I would commit the patch on 3.4 too. Patches that just fixes tests or 
documentation can be applied even at this stage.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25809] "Invalid" tests on locales

[Martin Panter]

Martin Panter added the comment:

Okay I am happy to do that, but I am unsure of the procedure. Do I just commit 
to 3.4, merge forward, and push? Would this be picked up in the final 3.4.4 
release, or only in a potential 3.4.5 release? Would I have to check with Larry 
first?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25809] "Invalid" tests on locales

[Roundup Robot]

Roundup Robot added the comment:

New changeset 4f24a6dc934b by Martin Panter in branch '3.5':
Issue #25809: Skip testing platform-dependent French thousands separator
https://hg.python.org/cpython/rev/4f24a6dc934b

New changeset 7c5c03143923 by Martin Panter in branch 'default':
Issue #25809: Merge French locale test from 3.5
https://hg.python.org/cpython/rev/7c5c03143923

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25809] "Invalid" tests on locales

[Roundup Robot]

Roundup Robot added the comment:

New changeset 903a2664d32d by Martin Panter in branch '2.7':
Issue #25809: Skip testing platform-dependent French thousands separator
https://hg.python.org/cpython/rev/903a2664d32d

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25809] "Invalid" tests on locales

[Marc-Andre Lemburg]

Marc-Andre Lemburg added the comment:

Same here. Thanks Martin.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25809] "Invalid" tests on locales

[Martin Panter]

Martin Panter added the comment:

Here is a patch that reverts to plain fr_FR and skips testing the thousands 
separator. This is what was tested before revision f9ff2a5bbbe2 (Issue 23474).

--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file41281/skip-thousands.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25809] "Invalid" tests on locales

[Martin Panter]

Martin Panter added the comment:

I meant revision b53aadd9cf85 in above message

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25809] "Invalid" tests on locales

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

LGTM.

--
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25809] "Invalid" tests on locales

[Martin Panter]

Martin Panter added the comment:

Some history:

1. Issue 23474 (Feb 2015): Testing fr_FR thousands_sep = ASCII space

2. Issue 24299 (Jun 2015): Changed to fr_FR.UTF-8 because Solaris uses the 
non-breaking space if it can be encoded as a single byte (i.e Latin-1)

So I tend to agree with Serhiy about changing back to the untested empty 
string. I don’t see the need to completely remove the whole test though.

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25809] "Invalid" tests on locales

[bapt]

New submission from bapt:

the locale tests the return value of locale functions against known good values.

The problem is when those known good values becomes wrong because of an update 
of the locales.

For example in recent CLDR definition the french separator for thousands in a 
"non breaking space" and not a space, while it used to be a space.
On released FreeBSD (very old db) it was a space. On GNU libc (a more recent db 
but still old :)) it is a space.On FreeBSD 11 and Dragonfly 4.4 it is a fairly 
new db (v27.0.1) with the fixed separator: 0xa0!

Thant makes this test fail.

I have no idea on the way you would prefer to fix that, either remove the test 
(not sure it is really relevant in the python testsuite) or patch it.

https://hg.python.org/cpython/file/tip/Lib/test/test__locale.py#l70
the failures can be seen here:
http://buildbot.python.org/all/buildslaves/koobs-freebsd11

--
components: Tests
messages: 255964
nosy: bapt, haypo
priority: normal
severity: normal
status: open
title: "Invalid" tests on locales
type: behavior
versions: Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25809] "Invalid" tests on locales

[SilentGhost]

Changes by SilentGhost :


--
nosy: +lemburg, loewis

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25809] "Invalid" tests on locales

[Marc-Andre Lemburg]

Marc-Andre Lemburg added the comment:

I see three options:

1. remove the French entry from the dict

2. enhance the test to accept multiple valid values

3. replace the French entry with a different locale that doesn't change the 
mapping often

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25809] "Invalid" tests on locales

[Zachary Ware]

Changes by Zachary Ware :


--
keywords: +buildbot
nosy: +zach.ware
stage:  -> needs patch
versions:  -Python 3.2, Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25809] "Invalid" tests on locales

[koobs]

Changes by koobs :


--
nosy: +koobs

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25809] "Invalid" tests on locales

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Originally the case for French was 'fr_FR': (',', ''). '' means "unknown" value 
and is not tested. We can return this value to omit test for thousand 
separator, or remove the French locale at all.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com