[issue25869] Faster ElementTree deepcopying

[Roundup Robot]

Roundup Robot added the comment:

New changeset 090c3e3a648d by Serhiy Storchaka in branch 'default':
Issue #25869: Optimized deepcopying ElementTree; it is now 20 times faster.
https://hg.python.org/cpython/rev/090c3e3a648d

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25869] Faster ElementTree deepcopying

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25869] Faster ElementTree deepcopying

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


Removed file: http://bugs.python.org/file41314/etree_deepcopy.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25869] Faster ElementTree deepcopying

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


Added file: http://bugs.python.org/file41316/etree_deepcopy.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25869] Faster ElementTree deepcopying

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


Added file: http://bugs.python.org/file41315/bench_etree_deepcopy.log

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25869] Faster ElementTree deepcopying

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

According to lxml benchmark [1], deepcopying a tree in ElementTree is about 20 
times slower than in lxml. Proposed patch optimizes deepcopying C 
implementation of ElementTree about 20 times. It is now 5% to 3 times faster 
than in lxml.

[1] http://lxml.de/performance.html

--
components: Extension Modules
files: etree_deepcopy.patch
keywords: patch
messages: 256455
nosy: brett.cannon, scoder, serhiy.storchaka
priority: normal
severity: normal
stage: patch review
status: open
title: Faster ElementTree deepcopying
type: performance
versions: Python 3.6
Added file: http://bugs.python.org/file41314/etree_deepcopy.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25869] Faster ElementTree deepcopying

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Updated patch correctly handles rare cases when different elements share the 
same attrib dict and when the same Element is occurred on different places in 
ElementTree (that is no longer a tree, but a directed graph).

--
Added file: http://bugs.python.org/file41317/etree_deepcopy2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com