[issue25941] Add 'How to Review a Patch' section to devguide

[Ned Deily]

Ned Deily added the comment:

The revised patch looks good to me (other than some trailing whitespace).  
Camilla, thanks for your contribution.  If you haven't already, please sign a 
contributor form to cover this and future contributions as noted elsewhere in 
the Developer's Guide:

https://docs.python.org/devguide/coredev.html#sign-a-contributor-agreement

--
nosy: +ned.deily
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25941] Add 'How to Review a Patch' section to devguide

[Roundup Robot]

Roundup Robot added the comment:

New changeset 8b3f4473432e by Ned Deily in branch 'default':
Issue #25941: Add "How To Review A Patch" section to the devguide.
https://hg.python.org/devguide/rev/8b3f4473432e

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25941] Add 'How to Review a Patch' section to devguide

[Camilla Montonen]

Camilla Montonen added the comment:

Thank you very much for your comments. I have cleaned up the previous patch and 
merged it with the Lifecycle of a Patch article.

--
Added file: http://bugs.python.org/file42893/patchreview18May.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25941] Add 'How to Review a Patch' section to devguide

[Ezio Melotti]

Ezio Melotti added the comment:

+1 to the above message.

There are also a couple of things that should be corrected:
* bugtracker -> bug tracker
* If the patch makes codechanges to C codebase -> If the patch affects any C 
file

This could also be condensed a bit and merged with 
https://docs.python.org/devguide/patch.html#reviewing instead of creating a new 
page.

--
stage:  -> patch review
type:  -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25941] Add 'How to Review a Patch' section to devguide

[SilentGhost]

SilentGhost added the comment:

Content of the article is in very reasonable shape, I have only couple of notes:
1. I don't think "production" is a good description of the python's repository 
workflow, so I'd suggest changing it to "repository".
2. Lack of links: instead of saying "check the devguide" a link to the relevant 
section would be useful. Though it applies even when no text is going to be 
saved.

Technically, there are couple more issues, such as extra empty lines at the 
start and end of file, page title should be followed by an empty line. Please 
trim all the trailing spaces. The list items should all have the same 
indentation. Importantly, please restrict width of each line to under 80 
characters: while a couple characters above this limit typically will do no 
harm, the lines should generally be of the same width. More links!

--
nosy: +SilentGhost

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25941] Add 'How to Review a Patch' section to devguide

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25941] Add 'How to Review a Patch' section to devguide

[Camilla Montonen]

New submission from Camilla Montonen:

This list is based on helpful tips and discussions received on the 
core-mentorship list and aims to help new beginners review patches in the bug 
tracker. The submitted patch is still in progress (the layout is a bit wonky 
and some details are still missing).

--
components: Devguide
files: patchreview.patch
keywords: patch
messages: 256970
nosy: Winterflower, ezio.melotti, willingc
priority: normal
severity: normal
status: open
title: Add 'How to Review a Patch' section to devguide
Added file: http://bugs.python.org/file41406/patchreview.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com