[issue26053] regression in pdb output between 2.7 and 3.5

[Irit Katriel]

Irit Katriel  added the comment:

Thanks, Victor.

I created a workflow issue for the CI question:
https://github.com/python/core-workflow/issues/393

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[miss-islington]

miss-islington  added the comment:


New changeset 2049bb2517c08b0d9eaaa4dd624afa5d60e8b5a8 by Miss Islington (bot) 
in branch '3.8':
[3.9] bpo-26053: Fix args echoed by pdb run command  (GH-25149)
https://github.com/python/cpython/commit/2049bb2517c08b0d9eaaa4dd624afa5d60e8b5a8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 6.0 -> 7.0
pull_requests: +23897
pull_request: https://github.com/python/cpython/pull/25150

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 7ad56e254519047aeb9c669b9ea2f2bf0acfd401 by Irit Katriel in 
branch '3.9':
[3.9] bpo-26053: Fix args echoed by pdb run command  (GH-25149)
https://github.com/python/cpython/commit/7ad56e254519047aeb9c669b9ea2f2bf0acfd401


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[Irit Katriel]

Change by Irit Katriel :


--
pull_requests: +23896
pull_request: https://github.com/python/cpython/pull/25149

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[STINNER Victor]

STINNER Victor  added the comment:

> If we want to backport then we need both PRs.

Commit 652bfdee9495dca241d48278742fe035b7a82bdb is a bugfix and this issue is 
marked as Python 3.8-3.10, so yeah, a backport is worth it.

You can create a PR for Python 3.9 combining the two commits. I like to use 
"git cherry-pick -x " manually for that. And then, use the label to 
backport this PR to Python 3.8.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[Irit Katriel]

Irit Katriel  added the comment:

It’s fixed now. The tests failed when we merged this old PR. I guess they 
passed a few months ago but something changed in the meantime.
I don’t know if there’s something to do in the CI to prevent this (expire the 
test run after a while?)

If we want to backport then we need both PRs.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[Guido van Rossum]

Guido van Rossum  added the comment:

Do you need my help here?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[STINNER Victor]

STINNER Victor  added the comment:


New changeset bd4ab8e73906a4f12d5353f567228b7c7497baf7 by Irit Katriel in 
branch 'master':
bpo-26053: Fix test_pdb.test_issue26053() (GH-25139)
https://github.com/python/cpython/commit/bd4ab8e73906a4f12d5353f567228b7c7497baf7


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[Irit Katriel]

Change by Irit Katriel :


--
pull_requests: +23886
pull_request: https://github.com/python/cpython/pull/25139

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[Guido van Rossum]

Guido van Rossum  added the comment:


New changeset 652bfdee9495dca241d48278742fe035b7a82bdb by Irit Katriel in 
branch 'master':
bpo-26053: Fix args echoed by pdb run command (#22033)
https://github.com/python/cpython/commit/652bfdee9495dca241d48278742fe035b7a82bdb


--
nosy: +gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[Tal Einat]

Tal Einat  added the comment:

Since it's a different implementation approach, I'd prefer a separate PR.

Whether we merge the existing one depends on whether we'd like to backport a 
fix for this to 3.9 and 3.8.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[Irit Katriel]

Irit Katriel  added the comment:

I like the idea of adding it to the Restart exception. Should we do this 
refactor in the same PR as fixing the regression or keep them separate?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[Tal Einat]

Tal Einat  added the comment:

I'm also uneasy about the sys.argv mangling.

It seem to me that it would be safer, and more explicit, to pass the desired 
arguments in the Restart exception instance.

--
nosy: +taleinat

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[Irit Katriel]

Change by Irit Katriel :


--
Removed message: https://bugs.python.org/msg377666

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[Irit Katriel]

Irit Katriel  added the comment:

As you see in the PR, this regression was in the commit I linked to which was 
made by Georg, but he has removed himself from the nosy list of this issue and 
was unavailable to review the PR when I asked him to. Can someone else review 
this?

It's a 1-line fix (reverting to previous) plus unit test.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[Georg Brandl]

Change by Georg Brandl :


--
nosy:  -georg.brandl

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[STINNER Victor]

Change by STINNER Victor :


--
nosy:  -vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[Irit Katriel]

Change by Irit Katriel :


--
components: +Library (Lib)
versions: +Python 3.10, Python 3.8, Python 3.9 -Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[Irit Katriel]

Change by Irit Katriel :


--
keywords: +patch
pull_requests: +21131
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/22033

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[Irit Katriel]

Irit Katriel  added the comment:

The regression was introduced here: 
https://github.com/python/cpython/commit/e023091815e4946e42c1af102be1f258b2f47cb8

in main() it prints " ".join(sys.argv[1:]) instead of " ".join(args).  

In do_run (line 1029) sys.argv gets updated with the arg for that particular 
"run" command:   sys.argv = shlex.split(arg)

The quickest fix would be to change main back to print sys.argv rather than 
arg. But I'm a little uneasy with a program modifying sys.argv (I wouldn't do 
it). So I'm wondering if that should be changed. What do you think?

--
nosy: +iritkatriel

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[Doug Hellmann]

New submission from Doug Hellmann:

Under python 2.7 using the "run" command within pdb and passing it arguments 
causes those arguments to be printed out. Under 3.5, this is no longer true.



$ python2.7 -m pdb pdb_run.py
> /Users/dhellmann/Dropbox/PyMOTW/Python3/pymotw-3/source/pdb/pdb_run.py(7)()
-> import sys
(Pdb) c
('Command-line args:', ['pdb_run.py'])
The program finished and will be restarted
> /Users/dhellmann/Dropbox/PyMOTW/Python3/pymotw-3/source/pdb/pdb_run.py(7)()
-> import sys
(Pdb) run a b c "this is a long argument"
Restarting pdb_run.py with arguments:
a b c this is a long argument
> /Users/dhellmann/Dropbox/PyMOTW/Python3/pymotw-3/source/pdb/pdb_run.py(7)()
-> import sys



$ python3.5 -m pdb pdb_run.py
> /Users/dhellmann/Dropbox/PyMOTW/Python3/pymotw-3/source/pdb/pdb_run.py(7)()
-> import sys
(Pdb) c
Command-line args: ['pdb_run.py']
The program finished and will be restarted
> /Users/dhellmann/Dropbox/PyMOTW/Python3/pymotw-3/source/pdb/pdb_run.py(7)()
-> import sys
(Pdb) run a b c "this is a long argument"
Restarting pdb_run.py with arguments:
pdb_run.py
> /Users/dhellmann/Dropbox/PyMOTW/Python3/pymotw-3/source/pdb/pdb_run.py(7)()
-> import sys


It looks like the issue is in the pdb main loop. Under 2.7 the restart logic 
has:

except Restart:
print "Restarting", mainpyfile, "with arguments:"
print "\t" + " ".join(sys.argv[1:])


but under 3.5 that was changed to:

except Restart:
print("Restarting", mainpyfile, "with arguments:")
print("\t" + " ".join(args))


The do_run() method has already reset sys.argv before throwing Restart, so to 
print the correct arguments sys.argv[1:] should be used.

--
files: pdb_run.py
keywords: 3.5regression
messages: 257785
nosy: doughellmann
priority: normal
severity: normal
status: open
title: regression in pdb output between 2.7 and 3.5
type: behavior
versions: Python 3.5, Python 3.6
Added file: http://bugs.python.org/file41538/pdb_run.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[Doug Hellmann]

Doug Hellmann added the comment:

I should also mention that I haven't tested early versions of 3.x to see where 
exactly the regression was introduced.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
nosy: +georg.brandl

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26053] regression in pdb output between 2.7 and 3.5

[STINNER Victor]

Changes by STINNER Victor :


--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com