[issue26067] test_shutil fails when gid name is missing

[Irit Katriel]

Change by Irit Katriel :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26067] test_shutil fails when gid name is missing

[Irit Katriel]

Irit Katriel  added the comment:

This seems complete, can it be closed?

--
nosy: +iritkatriel

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26067] test_shutil fails when gid name is missing

[Dino Viehland]

Dino Viehland  added the comment:


New changeset 52268941f37e3e27bd01792b081877ec3bc9ce12 by Matthias Braun in 
branch 'master':
bpo-26067: Do not fail test_shutil / chown when gid/uid cannot be resolved 
(#19032)
https://github.com/python/cpython/commit/52268941f37e3e27bd01792b081877ec3bc9ce12


--
nosy: +dino.viehland

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26067] test_shutil fails when gid name is missing

[Matthias Braun]

Matthias Braun  added the comment:

I have the same issue on my work macbook which has some form of network login 
configured. The primary group id of my user account there cannot be found in 
the group database and cannot be resolved to a name.

I'm not sure why that is but I am pretty sure there is no obligation that a gid 
must be resolvable to a name. I submitted a PR to just skip the last part of 
the test_shutil/chown if the uid/gid cannot be resolved to a name.

--
nosy: +Matthias Braun

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26067] test_shutil fails when gid name is missing

[Roundup Robot]

Change by Roundup Robot :


--
keywords: +patch
nosy: +python-dev
nosy_count: 3.0 -> 4.0
pull_requests: +18381
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/19032

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26067] test_shutil fails when gid name is missing

[Ezio Melotti]

Ezio Melotti added the comment:

We looked at this at the PyLadies Sprint in Helsinki.
When the group has an id but not a name (see "gid=203135016" in the "id" output 
-- the name is missing), its entry is missing from the list returned by 
grp.getgrall().

If this behaviour is expected and desired, then the test should be fixed to 
handle cases where the name is missing and the KeyError is raised.
Otherwise, the entry could still be included with "None" as name.

--
nosy: +serhiy.storchaka
stage:  -> needs patch
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26067] test_shutil fails when gid name is missing

[Dinesh Wijekoon]

Dinesh Wijekoon added the comment:

This reported bug occurred in Mac OS.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26067] test_shutil fails when gid name is missing

[Dinesh Wijekoon]

New submission from Dinesh Wijekoon:

./python.exe -m test -j3 -v test_shutil

The above test fails when id name is missing. The fail message is 
group = grp.getgrgid(gid)[0]
KeyError: 'getgrgid(): gid not found: 203135016'

Following is the results from console "id" command, when the failure happens. 

uid=1336551206(athukora) gid=203135016 
groups=203135016,402(com.apple.sharepoint.group.2),12(everyone),62(netaccounts),80(admin),401(com.apple.sharepoint.group.1),33(_appstore),98(_lpadmin),100(_lpoperator),204(_developer),398(com.apple.access_screensharing),399(com.apple.access_ssh)

And again when I change user to sudo the "id" command returns the following and 
test get passed.
uid=0(root) gid=0(wheel) 
groups=0(wheel),1(daemon),2(kmem),3(sys),4(tty),5(operator),8(procview),9(procmod),12(everyone),20(staff),29(certusers),61(localaccounts),80(admin),401(com.apple.sharepoint.group.1),402(com.apple.sharepoint.group.2),33(_appstore),98(_lpadmin),100(_lpoperator),204(_developer),398(com.apple.access_screensharing),399(com.apple.access_ssh)

PS:

We tried to debug this a bit and found the bug is possibly in 
Modules/grpmodule.c, may be at method grp_getgrall_impl. Adding 
"PyString_AsString(v);" before if command " PyList_Append(d, v) != 0" will fix 
the issue in test. But we have no idea how its working with this change.

--
components: Extension Modules
messages: 257858
nosy: Dinesh Wijekoon, ezio.melotti
priority: normal
severity: normal
status: open
title: test_shutil fails when gid name is missing
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com