[issue26079] Build with Visual Studio 2015 using PlatformToolset=v120

[Steve Dower]

Steve Dower added the comment:

Python 2.7 has a different section in its tcltk.props file and doesn't need 
this fix (yet).

Thanks for the patch, Bjoern!

--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26079] Build with Visual Studio 2015 using PlatformToolset=v120

[Roundup Robot]

Roundup Robot added the comment:

New changeset 7617f5b3f263 by Steve Dower in branch '3.5':
Issue #26079: Fixing the build output folder for tix-8.4.3.6. Patch by Bjoern 
Thiel.
https://hg.python.org/cpython/rev/7617f5b3f263

New changeset f426178c9d6c by Steve Dower in branch 'default':
Issue #26079: Fixing the build output folder for tix-8.4.3.6. Patch by Bjoern 
Thiel.
https://hg.python.org/cpython/rev/f426178c9d6c

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26079] Build with Visual Studio 2015 using PlatformToolset=v120

[Zachary Ware]

Zachary Ware added the comment:

Perhaps the ideal approach here would be to pass TMP_DIR and OUT_DIR into the 
Tcl/Tk builds, so we can tell them where to put stuff.  However, that would 
require major surgery to Tix's makefile to get it to build.  I'd be +1 on doing 
so (since we're pretty much the de-facto maintainers of Tix at this point, as 
far as I can tell), but am not enthusiastic about actually doing it.  I'd be 
much more enthusiastic about deprecating Tix.

Steve, if the patch as given is good enough for you, I'm fine with applying it.

--
assignee:  -> steve.dower

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26079] Build with Visual Studio 2015 using PlatformToolset=v120

[Steve Dower]

Steve Dower added the comment:

Go ahead. Feel free to add toolsets to cover ICC if you need them.

At one point I was passing through those directories for the build and it was 
not really trivial. A few too many places where it needed to be handled, but 
with patches against Tix it's probably disable.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26079] Build with Visual Studio 2015 using PlatformToolset=v120

[Bjoern Thiel]

New submission from Bjoern Thiel:

Fixing the build output folder for tix-8.4.3.6.

--
components: Build
files: build.patch
keywords: patch
messages: 257956
nosy: bjoernthiel
priority: normal
severity: normal
status: open
title: Build with Visual Studio 2015 using PlatformToolset=v120
type: crash
versions: Python 3.5
Added file: http://bugs.python.org/file41578/build.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26079] Build with Visual Studio 2015 using PlatformToolset=v120

[SilentGhost]

Changes by SilentGhost :


--
components: +Windows
nosy: +paul.moore, steve.dower, tim.golden, zach.ware
type: crash -> compile error

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26079] Build with Visual Studio 2015 using PlatformToolset=v120

[Steve Dower]

Steve Dower added the comment:

It's better than using the Visual Studio version, which isn't necessarily tied 
to any VC version. To support another compiler will require more code like this 
anyway.

An alternative may be to patch Tcl et al. to not put the VC version into the 
output path? That's likely to lead to different problems for people though...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26079] Build with Visual Studio 2015 using PlatformToolset=v120

[Zachary Ware]

Zachary Ware added the comment:

I'm on the fence about this one.  MSVC 12.0 is not officially supported for any 
Python release.  Also, using PlatformToolset makes things difficult for ICC 
builds (which set PlatformToolset to e.g. "Intel C++ Compiler 16.0").

On the other hand, this is a very simple change, and building tkinter with ICC 
is pretty well completely broken anyway (it only works if you first build 
Tcl/Tk with MSVC).

Call me +0; +1 if you can get around using PlatformToolset directly.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26079] Build with Visual Studio 2015 using PlatformToolset=v120

[Steve Dower]

Steve Dower added the comment:

Good catch! Once I'm at a PC I'll merge this in unless someone else gets there 
first. (I believe it also applies to 2.7 since the project files were updated.)

--
versions: +Python 2.7, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26079] Build with Visual Studio 2015 using PlatformToolset=v120

[Zachary Ware]

Zachary Ware added the comment:

The fewer patches we carry against Tcl/Tk the better.  This can be
revisited if necessary when other ICC issues with our Tcl/Tk build are
fixed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com