[issue26298] Split ceval.c into small files

2016-02-07 Thread Raymond Hettinger 

Raymond Hettinger added the comment:

I'm also -1 on the split for the reasons listed by Brett and Serhiy.

--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26298] Split ceval.c into small files

2016-02-05 Thread STINNER Victor 

New submission from STINNER Victor:

Attached patch splits the huge "switch (opcode)" of ceval.c into smaller 
ceval_xxx.h files. New files:

   93 Python/ceval_stack.h
  142 Python/ceval_condjump.h
  155 Python/ceval_misc.h
  162 Python/ceval_fast.h
  180 Python/ceval_module.h
  238 Python/ceval_ctx.h
  249 Python/ceval_func.h
  262 Python/ceval_iter.h
  268 Python/ceval_build.h
  384 Python/ceval_number.h

Maybe we can put more files per .h file, maybe less. I don't really care.

It will allow to keep the code readable even with new optimizations like the 
issue #21955.

What do you think?

--
files: split_ceval.patch
keywords: patch
messages: 259682
nosy: haypo, pitrou, serhiy.storchaka, yselivanov
priority: normal
severity: normal
status: open
title: Split ceval.c into small files
versions: Python 3.6
Added file: http://bugs.python.org/file41827/split_ceval.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26298] Split ceval.c into small files

2016-02-05 Thread Serhiy Storchaka 

Serhiy Storchaka added the comment:

I don't think this will make the code more readable. Rather less readable, 
since macros are defined in different file than used.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26298] Split ceval.c into small files

2016-02-05 Thread Brett Cannon 

Brett Cannon added the comment:

I have a similar worry as Serhiy as I don't know where to find something like 
GET_AWAITABLE with that organization.

--
nosy: +brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com