[issue26586] Simple enhancement to BaseHTTPRequestHandler

[Martin Panter]

Martin Panter added the comment:

I didn’t touch 2.7 because that doesn’t have the same header parsing code as 
Python 3.

--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed
versions:  -Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26586] Simple enhancement to BaseHTTPRequestHandler

[Roundup Robot]

Roundup Robot added the comment:

New changeset f5247195238f by Martin Panter in branch '3.5':
Issue #26586: Handle excessive header fields in http.server, by Xiang Zhang
https://hg.python.org/cpython/rev/f5247195238f

New changeset e8edddb4f74b by Martin Panter in branch 'default':
Issue #26586: Merge excessive HTTP header handling from 3.5
https://hg.python.org/cpython/rev/e8edddb4f74b

New changeset 1b696c744559 by Martin Panter in branch 'default':
Issue #26586: Simple enhancements to BaseHTTPRequestHandler by Xiang Zhang
https://hg.python.org/cpython/rev/1b696c744559

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26586] Simple enhancement to BaseHTTPRequestHandler

[Martin Panter]

Martin Panter added the comment:

I propose to commit the “Too many headers” handler as a bug fix, and the other 
changes to only 3.6. Currently when more than 100 header fields are sent, the 
connection is killed and the server logs an unhandled exception.

--
stage: patch review -> commit review
versions: +Python 2.7, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26586] Simple enhancement to BaseHTTPRequestHandler

[Xiang Zhang]

Xiang Zhang added the comment:

Ping.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26586] Simple enhancement to BaseHTTPRequestHandler

[Xiang Zhang]

Xiang Zhang added the comment:

Thanks for your review. I have made some changes according to it.

Status code 431 is returned when the header line is too long or there are too 
many headers. And I think the short message is OK and we can provide the 
exception message in the content message.

As for the style, I don't know why I made that change. Quite sorry for make the 
noise.

--
Added file: http://bugs.python.org/file42200/simple_enhancement_v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26586] Simple enhancement to BaseHTTPRequestHandler

[Xiang Zhang]

New submission from Xiang Zhang:

This patch propose several simple enhancement to BaseHTTPRequestHandler. It 
removes some redundant code and add handler for too many headers.

--
components: Library (Lib)
files: simple_enhancement.patch
keywords: patch
messages: 261946
nosy: xiang.zhang
priority: normal
severity: normal
status: open
title: Simple enhancement to BaseHTTPRequestHandler
type: enhancement
versions: Python 3.6
Added file: http://bugs.python.org/file42196/simple_enhancement.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26586] Simple enhancement to BaseHTTPRequestHandler

[Martin Panter]

Martin Panter added the comment:

Thanks for the patch, it looks good in general. I left some comments and 
suggestions.

--
nosy: +martin.panter
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com