[issue26837] assertSequenceEqual() raises BytesWarning when format message

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you for your helpful review Martin!

--
assignee:  -> serhiy.storchaka
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26837] assertSequenceEqual() raises BytesWarning when format message

[Roundup Robot]

Roundup Robot added the comment:

New changeset ae5cc8ab664a by Serhiy Storchaka in branch '3.5':
Issue #26837: assertSequenceEqual() now correctly outputs non-stringified
https://hg.python.org/cpython/rev/ae5cc8ab664a

New changeset d0d541c2afb7 by Serhiy Storchaka in branch '2.7':
Issue #26837: assertSequenceEqual() now correctly outputs non-stringified
https://hg.python.org/cpython/rev/d0d541c2afb7

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26837] assertSequenceEqual() raises BytesWarning when format message

[Martin Panter]

Martin Panter added the comment:

I think the change is good in spirit, especially using repr() and limiting the 
size. See the review for a couple problems.

--
nosy: +martin.panter
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26837] assertSequenceEqual() raises BytesWarning when format message

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

assertSequenceEqual() raises BytesWarning when format failure report. See for 
example 
http://buildbot.python.org/all/builders/AMD64%20OpenIndiana%203.x/builds/10575/steps/test/logs/stdio
 :

==
ERROR: test_close_fds_0_1 (test.test_subprocess.POSIXProcessTestCase)
--
Traceback (most recent call last):
  File 
"/export/home/buildbot/64bits/3.x.cea-indiana-amd64/build/Lib/test/test_subprocess.py",
 line 1741, in test_close_fds_0_1
self.check_close_std_fds([0, 1])
  File 
"/export/home/buildbot/64bits/3.x.cea-indiana-amd64/build/Lib/test/test_subprocess.py",
 line 1727, in check_close_std_fds
self.assertEqual((out, err), (b'apple', b'orange'))
  File 
"/export/home/buildbot/64bits/3.x.cea-indiana-amd64/build/Lib/unittest/case.py",
 line 820, in assertEqual
assertion_func(first, second, msg=msg)
  File 
"/export/home/buildbot/64bits/3.x.cea-indiana-amd64/build/Lib/unittest/case.py",
 line 1029, in assertTupleEqual
self.assertSequenceEqual(tuple1, tuple2, msg, seq_type=tuple)
  File 
"/export/home/buildbot/64bits/3.x.cea-indiana-amd64/build/Lib/unittest/case.py",
 line 967, in assertSequenceEqual
(i, item1, item2))
BytesWarning: str() on a bytes instance

==

Proposed patch fixes message formatting and adds tests for assertions that can 
emit BytesWarning.

--
components: Library (Lib), Tests
files: unittest_assert_bytes_warning.patch
keywords: patch
messages: 264110
nosy: ezio.melotti, michael.foord, rbcollins, serhiy.storchaka
priority: normal
severity: normal
status: open
title: assertSequenceEqual() raises BytesWarning when format message
type: behavior
versions: Python 2.7, Python 3.5, Python 3.6
Added file: http://bugs.python.org/file42581/unittest_assert_bytes_warning.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com