[issue26935] android: test_os fails

[Xavier de Gaye]

Changes by Xavier de Gaye :


--
dependencies:  -android: add platform.android_ver()
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26935] android: test_os fails

[Roundup Robot]

Roundup Robot added the comment:

New changeset 80e4cb5888f3 by Xavier de Gaye in branch '3.6':
Issue #26935: Fix broken Android dup2() in test_os
https://hg.python.org/cpython/rev/80e4cb5888f3

New changeset da59b7084dbe by Xavier de Gaye in branch 'default':
Issue #26935: Merge 3.6
https://hg.python.org/cpython/rev/da59b7084dbe

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26935] android: test_os fails

[Xavier de Gaye]

Xavier de Gaye added the comment:

New patch. Thanks for the review Martin!

--
Added file: http://bugs.python.org/file45368/test_urandom_fd_reopened_3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26935] android: test_os fails

[Xavier de Gaye]

Xavier de Gaye added the comment:

This new patch takes into account Martin comment in msg265099 and fixes a call 
to getpwall() as Android does not have getpwall().

--
assignee:  -> xdegaye
stage: patch review -> commit review
versions: +Python 3.7
Added file: http://bugs.python.org/file45335/test_urandom_fd_reopened_2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26935] android: test_os fails

[Xavier de Gaye]

Xavier de Gaye added the comment:

This is fixed at API 23 (Android 6.0) and test_os runs on an android-23-x86 
emulator without failures.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26935] android: test_os fails

[Chi Hsuan Yen]

Chi Hsuan Yen added the comment:

My implementation at #26855 returns a tuple of strings like other funcitons, 
including java_ver() and mac_ver(). Maybe it requires a change.

--
nosy: +Chi Hsuan Yen

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26935] android: test_os fails

[Martin Panter]

Martin Panter added the comment:

Yes something like that should do the trick

--
components: +Tests -Cross-Build, Library (Lib)
dependencies: +android: add platform.android_ver()

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26935] android: test_os fails

[Xavier de Gaye]

Xavier de Gaye added the comment:

Since this seems to be fixed in a version of android that is more recent that 
API 21, maybe use the value of 'sdk.release' when platform.android_ver() is 
available after issue #26855 is fixed, with for example, if this is fixed at 
API 23:

sdk_release = platform.android_ver()[1]
if new_fd != fd or not sdk_release or sdk_release >= 23:

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26935] android: test_os fails

[Martin Panter]

Martin Panter added the comment:

I think this is an Android bug. See specification 
, fix 
.

If the change is to go into Python, it would be good to include a comment 
admitting it is an Android workaround, rather than a general deficiency.

--
nosy: +martin.panter
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26935] android: test_os fails

[Xavier de Gaye]

Xavier de Gaye added the comment:

On android dup2() returns with an error when both fds are the same:

root@generic_x86:/data/local/tmp # python
Python 3.6.0a0 (default:811ccdee6f87+, May  7 2016, 12:44:06) 
[GCC 4.9 20140827 (prerelease)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import os
>>> os.dup2(1, 1)
Traceback (most recent call last):
  File "", line 1, in 
OSError: [Errno 22] Invalid argument


The attached patch fixes this in test_urandom_fd_reopened.

--
keywords: +patch
Added file: http://bugs.python.org/file42768/test_urandom_fd_reopened.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26935] android: test_os fails

[Xavier de Gaye]

New submission from Xavier de Gaye:

One test of test_os fails on an android emulator running an x86 system image at 
API level 21.

See the attached test_output.txt file.

--
components: Cross-Build, Library (Lib)
files: test_output.txt
messages: 264736
nosy: Alex.Willmer, loewis, xdegaye
priority: normal
severity: normal
status: open
title: android: test_os fails
type: behavior
versions: Python 3.6
Added file: http://bugs.python.org/file42700/test_output.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com