[issue27131] Unit test random shuffle

[Raymond Hettinger]

Raymond Hettinger added the comment:

I've just looked at the existing tests for random.shuffle() and found that they 
already cover this case and do a much more thorough job.  The suggested patch 
doesn't add anything.   Sorry, I'm going to close this one -- there isn't any 
problem being solved.

--
resolution:  -> rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27131] Unit test random shuffle

[Jonathan Kross]

Jonathan Kross added the comment:

Just giving this one a bump to see if it can be applied soon.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27131] Unit test random shuffle

[Jonathan Kross]

Jonathan Kross added the comment:

Just giving this one a bump to see if it can be applied soon.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27131] Unit test random shuffle

[Raymond Hettinger]

Raymond Hettinger added the comment:

Yes

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27131] Unit test random shuffle

[Jonathan Kross]

Jonathan Kross added the comment:

Just checking in on this patch. Any chance of getting it applied within the 
next few days?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27131] Unit test random shuffle

[Raymond Hettinger]

Raymond Hettinger added the comment:

Okay, this looks fine.  I'll apply it within a few days.

--
assignee:  -> rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27131] Unit test random shuffle

[jonathan.kross]

jonathan.kross added the comment:

Changed the test to assertCountEqual which will check that all the inputs are 
present and equal in the output.

--
Added file: http://bugs.python.org/file43019/test_random_shuffle.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27131] Unit test random shuffle

[Raymond Hettinger]

New submission from Raymond Hettinger:

This tests that a specific shuffle result is obtained (which is an 
implementation specific detail subject to change).  An alternate possible test 
would just check to see that all the inputs are present in the output.

--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27131] Unit test random shuffle

[jonathan.kross]

Changes by jonathan.kross :


--
components: Tests
files: test_random_shuffle.patch
keywords: patch
nosy: jonathan.kross
priority: normal
severity: normal
status: open
title: Unit test random shuffle
versions: Python 3.6
Added file: http://bugs.python.org/file43017/test_random_shuffle.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com