[issue27245] IDLE: Fix deletion of custom themes and key bindings

[Terry J. Reedy]

Terry J. Reedy added the comment:

In #4765, which I just closed as a duplicate, G Polo had same idea of applying 
change at top.
https://bugs.python.org/file14645/removekeybindingswhiletheyexist.diff

--
assignee:  -> terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27245] IDLE: Fix deletion of custom themes and key bindings

[Terry J. Reedy]

Terry J. Reedy added the comment:

Patch amounts to putting 3 lines of apply inline and moving the first up to 
where is it needed.  Serhiy, thanks for discovering the simple fix.  It worked 
for me so I pushed it.  I backported because the cascade of error messages is 
nasty when visible and because the forward merge was easy enough now that I 
know about the case clash problem.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27245] IDLE: Fix deletion of custom themes and key bindings

[Roundup Robot]

Roundup Robot added the comment:

New changeset 3ac9e7466d8b by Terry Jan Reedy in branch 'default':
Issue #27245: revert temporary rename
https://hg.python.org/cpython/rev/3ac9e7466d8b

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27245] IDLE: Fix deletion of custom themes and key bindings

[Roundup Robot]

Roundup Robot added the comment:

New changeset 5c8cddc4a8ee by Terry Jan Reedy in branch '2.7':
Issue #27245: IDLE: Cleanly delete custom themes and key bindings.
https://hg.python.org/cpython/rev/5c8cddc4a8ee

New changeset 438359d00a83 by Terry Jan Reedy in branch '3.5':
Issue #27245: IDLE: Cleanly delete custom themes and key bindings.
https://hg.python.org/cpython/rev/438359d00a83

New changeset 7948633608d5 by Terry Jan Reedy in branch 'default':
Issue #27245: temporary rename for merge.
https://hg.python.org/cpython/rev/7948633608d5

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27245] IDLE: Fix deletion of custom themes and key bindings

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Proposed patch should fix this issue.

--
components: +IDLE
keywords: +patch
nosy: +serhiy.storchaka
stage: test needed -> patch review
versions: +Python 2.7, Python 3.5
Added file: http://bugs.python.org/file43275/idle_delete_current_theme.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27245] IDLE: Fix deletion of custom themes and key bindings

[Terry J. Reedy]

New submission from Terry J. Reedy:

Open IDLE by running from console or importing idlelib.idle in interactive 
Python window.  In the IDLE Preferences dialog, create a new custom theme or 
key set.  [Apply] or close with [OK].  Reopen, if necessary, select the new 
custom set as current, select Delete, and Apply or close.  IDLE will delete the 
set and then try to read it.  A warning message will appear in the 
console/interpreter for each item in the set that is had to replace with the 
default value.

IDLE should replace the deleted set with one of the builtins before reading, or 
even better, allow and require deletion of something that is not current.

--
messages: 267580
nosy: terry.reedy
priority: normal
severity: normal
stage: test needed
status: open
title: IDLE: Fix deletion of custom themes and key bindings
type: behavior
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com