[issue2744] Fix test_cProfile

[Benjamin Peterson]

New submission from Benjamin Peterson <[EMAIL PROTECTED]>:

test_cProfile has been disabled in Py3k for a while now. It should be
fixed before release.

--
messages: 66131
nosy: benjamin.peterson
priority: critical
severity: normal
status: open
title: Fix test_cProfile
versions: Python 3.0

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2744] Fix test_cProfile

[Brett Cannon]

Brett Cannon <[EMAIL PROTECTED]> added the comment:

A key thing to realize is that test_cprofile has heavily changed in
2.6 compared to what is currently disabled in 3.0.

--
nosy: +brett.cannon

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2744] Fix test_cProfile

[Mark Lawrence]

Mark Lawrence  added the comment:

Is there anybody who can run with this as it's been in limbo for over two years?

--
nosy: +BreamoreBoy
versions: +Python 2.7, Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2744] Fix test_cProfile

[Mark Lawrence]

Mark Lawrence  added the comment:

Nobody has responded to msg109475 so I'll close unless there are any objections.

--
priority: high -> normal
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2744] Fix test_cProfile

[Mark Dickinson]

Mark Dickinson  added the comment:

> I'll close unless there are any objections.

Yes, I object! :)

If there's still a bug present, it seems inappropriate to close this issue.  So 
as a first step, someone needs to look at this closely to determine whether 
there *is* still a problem that needs fixing.  (It's not clear to me at the 
moment whether that's true.)

--
nosy: +mark.dickinson
status: pending -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2744] Fix test_cProfile

[Brett Cannon]

Changes by Brett Cannon :


--
resolution:  -> out of date
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2744] Fix test_cProfile

[Alexandre Vassalotti]

Alexandre Vassalotti <[EMAIL PROTECTED]> added the comment:

I will try to fix this one with profile/cProfile merge.

--
assignee:  -> alexandre.vassalotti
nosy: +alexandre.vassalotti

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2744] Fix test_cProfile

[Benjamin Peterson]

Benjamin Peterson <[EMAIL PROTECTED]> added the comment:

Alexandre, are you still computerless?

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2744] Fix test_cProfile

[Alexandre Vassalotti]

Alexandre Vassalotti <[EMAIL PROTECTED]> added the comment:

Not anymore! :-)

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2744] Fix test_cProfile

[Benjamin Peterson]

Changes by Benjamin Peterson <[EMAIL PROTECTED]>:


--
versions: +Python 3.1 -Python 3.0

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2744] Fix test_cProfile

[Neal Norwitz]

Changes by Neal Norwitz <[EMAIL PROTECTED]>:


--
priority: critical -> release blocker

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2744] Fix test_cProfile

[Brett Cannon]

Brett Cannon <[EMAIL PROTECTED]> added the comment:

So is this going to be a 3.1 issue or a 3.0 one? If it's the former then
it should not be a release blocker. But if is going to be for 3.0 then
the version list is wrong.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2744] Fix test_cProfile

[Barry A. Warsaw]

Barry A. Warsaw <[EMAIL PROTECTED]> added the comment:

I guess since this hasn't been done by now, it's not going to get done
for 3.0, so I'm lowering the priority on it.

--
nosy: +barry
priority: release blocker -> critical

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2744] Fix test_cProfile

[Benjamin Peterson]

Benjamin Peterson <[EMAIL PROTECTED]> added the comment:

Done in r66817.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2744] Fix test_cProfile

[Alexandre Vassalotti]

Alexandre Vassalotti <[EMAIL PROTECTED]> added the comment:

Have you verified the numbers? They don't look right to me.

The problem is the 2nd argument of cProfile's constructor has a
different semantic meaning than the one for profile.py. For profile.py,
it is used to set the "bias" (I presume it means the overhead) of the
profiler. But for cProfile, it's the unit (in seconds?) of timer used.

Personally, I have no idea which semantic should be preferred. So
perhaps, the best thing to do for now is remove the second argument from
the cls.profilerclass() call in test_profile.ProfileTest:

class ProfileTest:
...
def do_profiling(cls):
...
prof = cls.profilerclass(timer, 0.001)
...

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2744] Fix test_cProfile

[Benjamin Peterson]

Benjamin Peterson <[EMAIL PROTECTED]> added the comment:

No, I didn't look too hard at it; I just got it scraping along, so I can
forward port a fix for it. I'll reopen this, so you can take more
action, so you wish. :)

--
resolution: fixed -> 
status: closed -> open

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2744] Fix test_cProfile

[Alexandre Vassalotti]

Alexandre Vassalotti <[EMAIL PROTECTED]> added the comment:

Unassigning myself as I don't have the time to fix this properly.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2744] Fix test_cProfile

[Alexandre Vassalotti]

Changes by Alexandre Vassalotti <[EMAIL PROTECTED]>:


--
assignee: alexandre.vassalotti -> 

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2744] Fix test_cProfile

[Benjamin Peterson]

Changes by Benjamin Peterson <[EMAIL PROTECTED]>:


--
priority: critical -> high

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com