[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Elias Zamaria]

Elias Zamaria  added the comment:

Can someone here merge my pull request? If not, then what else needs to be done 
for my change to be included in 3.7?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

I don't think these changes should be merged.

For bytes.zeros(N), you can use b'\0' * N.

For iterbytes() methods, I think that the general function which works with any 
sequence that support slicing would be more useful.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Elias Zamaria]

Elias Zamaria  added the comment:

What else needs to be done with this issue? Can someone merge my pull request?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[INADA Naoki]

INADA Naoki  added the comment:

PEP should be accepted before review and merge.
So what you can do is restart discussion on ML again.

--
nosy: +inada.naoki

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Elias Zamaria]

Elias Zamaria  added the comment:

INADA, what is ML? How do I restart the discussion?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[INADA Naoki]

INADA Naoki  added the comment:

ML meant mailing list.
There is guide for it.
http://devguide.python.org/communication/

If you really want this new API, you can search previous discussion and post 
new mail with summary of the previous discussion.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[amirjn]

amirjn  added the comment:

i didnt find anything at http://devguide.python.org/communication/

--
nosy: +amirjn

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[amirjn]

amirjn  added the comment:

We got same problem at https://www.blogs.va.gov/ 
can any one help?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[INADA Naoki]

INADA Naoki  added the comment:

Hmm, can you read this instead?
https://github.com/python/devguide/blob/master/communication.rst

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Ned Deily]

Change by Ned Deily :


--
versions: +Python 3.8 -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Elias Zamaria]

New submission from Elias Zamaria:

This is my attempt at implementing PEP 467.

I am not an expert in the details of the Python interpreter, and this is my 
first time working on a big project in C, so I am not sure if I am doing things 
in the most elegant or efficient way, but it seems to work fine, as far as I 
can tell.

I have added some tests for the new functionality. I am planning to work on 
changes to the documentation some time in the next few days.

I noticed a lot of places that are using the deprecated integer-argument bytes 
and bytearray constructors. I left most of them alone, although I changed a few 
of them to the zeros constructors to prevent certain tests from failing.

--
components: Interpreter Core
files: pep467.patch
keywords: patch
messages: 274082
nosy: mikez302
priority: normal
severity: normal
status: open
title: PEP 467 -- Minor API improvements for binary sequences
type: enhancement
versions: Python 3.6
Added file: http://bugs.python.org/file44312/pep467.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Ethan Furman]

Changes by Ethan Furman :


--
nosy: +ethan.furman

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Elias Zamaria]

Elias Zamaria added the comment:

Here is a patch with some changes to the docs. I don't know if the descriptions 
are good enough, but it should hopefully identify what parts of the docs need 
to be changed.

--
Added file: http://bugs.python.org/file44313/pep467_doc_changes.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Martin Panter]

Martin Panter added the comment:

FYI if you rebase your patches onto public Mercurial revisions, they should get 
a review link

--
nosy: +martin.panter
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Elias Zamaria]

Elias Zamaria added the comment:

@martin.panter, I am familiar with Mercurial, and with the concept of rebasing, 
but I don't understand what you are trying to tell me.

I made these changes in several local branches, and then merged them all 
together in one branch. How can I rebase it onto a public revision? Can I just 
do it, or do I need some sort of special privileges?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Martin Panter]

Martin Panter added the comment:

Here is what I did. (You could probably do this yourself, but never mind :)

hg pull -r{default,2.7,3.5}
hg update default  # Update to the latest public revision
hg import --no-commit "$(xclip -o)"  # Apply your patch on top
hg diff -p > pep467.patch  # Make a new diff

If you look inside the patch file, the difference is that the Reitveld review 
system cannot handle “diff -r 3e41c0449b9c” from your file, but hopefully will 
know about “diff -r ebb23744a36c” in my version.

--
Added file: http://bugs.python.org/file44316/pep467.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Martin Panter]

Changes by Martin Panter :


Added file: http://bugs.python.org/file44317/pep467_doc_changes.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Martin Panter]

Martin Panter added the comment:

Thanks for the patches. I left you some comments in the code review.

I expect there would be more bits of the docs that need fixing. 
Doc/library/functions.rst definitely; the tutorial is worth checking too. There 
may also be example code floating around using the deprecated calls.

Regarding code that uses the deprecated call, as well as blind searching 
(grep), you could try running the entire test suite with -Werror. That should 
catch a lot of them.

In the RST documentation, I think you missed adding entries for the zeros() and 
byte() constructor methods. Maybe use the other class methods maketrans(), 
fromhex() as a starting point.

Also, this will need an entry written for Doc/whatsnew/3.6.rst.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Elias Zamaria]

Elias Zamaria added the comment:

I tried running `hg import --no-commit "$(xclip -o)"` and got the following 
result:

bash: xclip: command not found
abort: need at least one patch to import

I am using OS X 10.11.6 and Mercurial 3.8.2. I did a bit of quick research on 
xclip, but it looks like yet another unfamiliar tool, and I don't know exactly 
what it does or how it is supposed to help me.

I looked at your suggestions for my patch, and I am working on them.

I am planning to look at the tutorial, and to look for, and maybe fix, 
deprecated calls, but so far, I don't have a clear idea how long it will take 
me, or if it is realistic for one person to do it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I'm not convinced that the zeros() method is needed. Zero-initialized sequences 
can be created via sequence repetition. Sorry, but arguments against this sound 
like "we made bad design decision in the past, let repeat it with new name" to 
me.

In any case if you want to write a code for different Python versions you 
should use sequence repetition.

Here is a patch that replaces all creations of zero-initialized bytes and 
bytearray objects in the stdlib and tests with repetitions. All tests (except 
test_bytes of course) are passed on Linux if disallow an int argument in bytes 
and bytearray constructors.

--
nosy: +serhiy.storchaka
Added file: http://bugs.python.org/file44329/no_bytes_from_int.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Ethan Furman]

Ethan Furman added the comment:

Two things to note:

- there is no need to change the stdlib to use anything besides the default
  constructor -- it's not going away, and it already works (my apologies if
  I misunderstood)

- PEP 467 has not yet been accepted (unless I missed that?)

However, thank you for getting some code written!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Elias Zamaria]

Elias Zamaria added the comment:

Here is a patch with all of my latest changes, including the changes that 
Martin suggested for the tests.

--
Added file: http://bugs.python.org/file44332/pep467_attempt2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Martin Panter]

Martin Panter added the comment:

Sorry Elias for not explaining my commands. xclip was just my way of pasting 
the patch URL from the clipboard (that I copied from Firefox).

It is not clear if we are actually making a DeprecationWarning, or going down 
the road of changing all the stdlib. But if we do, there are a couple of bits 
of Serhiy’s patch that I would rewrite more plainly, e.g. bytearray(b'\0\0') * 
len(...) instead of bytearray(b'\0') * (2 * len(...)).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Elias Zamaria]

Elias Zamaria added the comment:

Martin, where am I supposed to get the patch URL from?

Also, is it too soon to issue DeprecationWarnings? Would it be more appropriate 
if they are PendingDeprecationWarnings instead?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Martin Panter]

Martin Panter added the comment:

Elias, the patch URL is where I downloaded your patch from; see the list of 
patches at the top of this bug:

hg import --no-commit https://bugs.python.org/file44316/pep467.patch

Anyway in this email 
 it seems Ethan only 
wants to document that the old constructor call is deprecated, and not issue a 
DeprecationWarning.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Elias Zamaria]

Elias Zamaria added the comment:

Martin, I made another attempt to understand what you are trying to tell me 
about the patch, and I'm still confused.

It seems that to make the patch merge cleanly, I need to get the patch URL from 
this page, and to get the patch URL, I need to upload the patch, and to upload 
the patch, I need to produce the patch, and to produce a patch that merges 
cleanly, I need to get the patch URL. That sounds like a catch-22. Where am I 
supposed to start?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Elias Zamaria]

Elias Zamaria added the comment:

I looked through the email thread. I can remove the DeprecationWarnings, but 
before I do that, I would like to ask something: How "official" are the things 
discussed in the thread? Are they supposed to be part of the PEP? Are they 
supposed to be final, definite decisions, or are they things that may change 
soon?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Ethan Furman]

Ethan Furman added the comment:

The PEP 467 has not been accepted yet, so nothing is final.  The email thread 
is the current discussion.

Also, unless someone has received permission from Ned, this won't go in until 
Python 3.7.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Elias Zamaria]

Elias Zamaria added the comment:

Ethan, by "Ned", I am guessing that you are referring to Ned Batchelder. Is 
that right? If so, do we need to put him on the nosy list or do anything else 
to bring this to his attention?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Ned Deily]

Ned Deily added the comment:

I agree with Ethan that the PEP needs to be accepted first and afterwards, 
unless there is a very strong case made quickly, it would not qualify for a 
late-feature exemption for 360b2.

Nick, any updates on the status of PEP 467?

--
nosy: +ncoghlan, ned.deily
versions: +Python 3.7 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Nick Coghlan]

Nick Coghlan added the comment:

Just what Ethan noted above, and the fact that Ethan should also list himself 
as a co-author now :)

That said, one major alternative it would be good to consider further between 
now and 3.7 is Serhiy's "seqtools" idea: 
https://mail.python.org/pipermail/python-ideas/2016-July/041083.html

Something that wrapped memoryview and allowed bytes-based iteration over any 
buffer exported would automatically cover bytes and bytearray as well, while 
also permitting "structure ignoring" iteration over the raw data contained in 
other types.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Andreas Gnau]

Changes by Andreas Gnau :


--
nosy: +Rondom

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Nick Coghlan]

Nick Coghlan added the comment:

Something else the PEP needs to be updated to cover is that in 3.5+ (and maybe 
even in 3.4 - I'm not sure when 'c' support landed in memoryview) you can write 
the following efficient bytes iterator:

def iterbytes(data):
return iter(memoryview(data).cast('c'))

And use it as so:

>>> data = b"123"
>>> for datum in iterbytes(data):
... print(datum)
... 
b'1'
b'2'
b'3'

That will then work with any buffer exporter, not just bytes and bytearray, and 
since it's a function, you can easily make a similar function that's 
polymorphic on str -> str iterator and bytes-like -> bytes iterator.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Even in 3.3+.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Martin Panter]

Martin Panter added the comment:

For arbitrary C-contiguous buffers aka “bytes-like objects” (which are not just 
arrays of bytes), I think this trick relies on Issue 15944, which is only added 
in 3.5+.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Elias Zamaria]

Changes by Elias Zamaria :


--
pull_requests: +3279

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[amirjn]

amirjn  added the comment:

Thank you Inda Naoki. It just worked for me in https://www.blogs.va.gov/ and 
https://aralens.ir

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27923] PEP 467 -- Minor API improvements for binary sequences

[Ethan Furman]

Change by Ethan Furman :


--
assignee:  -> ethan.furman

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com