[issue27931] Email parse IndexError <""@wiarcom.com>

[Xiang Zhang]

Change by Xiang Zhang :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27931] Email parse IndexError <""@wiarcom.com>

[Mariatta Wijaya]

Mariatta Wijaya  added the comment:


New changeset 6ea75b174da0cf824e2acc5db6b53798f5f4e4f9 by Mariatta (Miss 
Islington (bot)) in branch '3.6':
bpo-27931: Fix email address header parsing error (GH-5329) (GH-5431)
https://github.com/python/cpython/commit/6ea75b174da0cf824e2acc5db6b53798f5f4e4f9


--
nosy: +Mariatta

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27931] Email parse IndexError <""@wiarcom.com>

[miss-islington]

Change by miss-islington :


--
pull_requests: +5266

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27931] Email parse IndexError <""@wiarcom.com>

[R. David Murray]

R. David Murray  added the comment:


New changeset aa218d1649690d1c1ba86a9972f7fae646bf1a8f by R. David Murray 
(jayyyin) in branch 'master':
bpo-27931: Fix email address header parsing error (#5329)
https://github.com/python/cpython/commit/aa218d1649690d1c1ba86a9972f7fae646bf1a8f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27931] Email parse IndexError <""@wiarcom.com>

[Jay Yin]

Jay Yin  added the comment:

https://github.com/python/cpython/pull/5329
this is the pending pull request for this

--
nosy: +jayyin11043

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27931] Email parse IndexError <""@wiarcom.com>

[Xiang Zhang]

Change by Xiang Zhang :


--
type:  -> behavior
versions: +Python 3.7 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27931] Email parse IndexError <""@wiarcom.com>

[Jay Yin]

Change by Jay Yin :


--
pull_requests: +5174
stage: commit review -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27931] Email parse IndexError <""@wiarcom.com>

[Константин Волков]

Константин Волков  added the comment:

ping

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27931] Email parse IndexError <""@wiarcom.com>

[Константин Волков]

Константин Волков added the comment:

ping

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27931] Email parse IndexError <""@wiarcom.com>

[Xiang Zhang]

Xiang Zhang added the comment:

Ping.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27931] Email parse IndexError <""@wiarcom.com>

[Xiang Zhang]

Xiang Zhang added the comment:

You are right David. But I don't understand what it has to do with 
headerregistry. I update my original patch to get that behaviour, limit it the 
affection in angleaddr. Now seems everything is fine.

>>> email._header_value_parser.get_angle_addr('<""@wiarcom.com> 
>>> SIZE=28113')[0].local_part
''
>>> email._header_value_parser.get_angle_addr('<""@wiarcom.com> 
>>> SIZE=28113')[0].domain
'wiarcom.com'
>>> email._header_value_parser.get_angle_addr('<""@wiarcom.com> 
>>> SIZE=28113')[0].route
>>> email._header_value_parser.get_angle_addr('<""@wiarcom.com> 
>>> SIZE=28113')[0].addr_spec
'""@wiarcom.com'

--
Added file: http://bugs.python.org/file44523/issue27931_v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27931] Email parse IndexError <""@wiarcom.com>

[R. David Murray]

R. David Murray added the comment:

Reviewed.  There is something else that needs fixing.  The address needs to 
re-render as ""@wiarcom.com, which it doesn't currently.  I scanned the 
rendering code in _header_value_registry quickly and its not obvious to me why 
it doesn't work, so it may be a bug in the headerregistry.Address object.  I'm 
uploading the patch with the added test.

--
Added file: http://bugs.python.org/file44516/issue27931.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27931] Email parse IndexError <""@wiarcom.com>

[Xiang Zhang]

Xiang Zhang added the comment:

Ping this and hope you don't forget about it David. :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27931] Email parse IndexError <""@wiarcom.com>

[Xiang Zhang]

Xiang Zhang added the comment:

It should be. If there is anything wrong I'd like to hear and fix.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27931] Email parse IndexError <""@wiarcom.com>

[R. David Murray]

R. David Murray added the comment:

You are correct, it is technically a valid angleaddr.  I'll review this next 
week, the patch looks good (thanks) but I need to double check a couple things 
before I commit.

--
assignee:  -> r.david.murray
stage: needs patch -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27931] Email parse IndexError <""@wiarcom.com>

[Xiang Zhang]

Xiang Zhang added the comment:

Looking at the spec this is a valid angle addr. Not only 
et_angle_addr('<""@wiarcom.com> SIZE=28113')[0].addr_spec but also 
et_angle_addr('<""@wiarcom.com> SIZE=28113')[0].local_part fails for the same 
reason.

The problem exists in get_bare_quoted_string. When encounter bare '""', it 
returns a empty BareQuoteString. I write issue27931.patch to fix this.

--
keywords: +patch
nosy: +xiang.zhang
Added file: http://bugs.python.org/file44340/issue27931.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27931] Email parse IndexError <""@wiarcom.com>

[R. David Murray]

Changes by R. David Murray :


--
stage:  -> needs patch
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27931] Email parse IndexError <""@wiarcom.com>

[Константин Волков]

New submission from Константин Волков:

Email lib fails to parse some emails:

from email._header_value_parser import get_angle_addr
get_angle_addr('<""@wiarcom.com> SIZE=28113').addr_spec

IndexError: list index out of range

Seems that email address can be parsed.

--
components: email
messages: 274140
nosy: barry, r.david.murray, Константин Волков
priority: normal
severity: normal
status: open
title: Email parse IndexError <""@wiarcom.com>
versions: Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com