[issue28002] ast.unparse can't roundtrip some f-strings

[Eric V. Smith]

Change by Eric V. Smith :


--
resolution: not a bug -> fixed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28002] ast.unparse can't roundtrip some f-strings

[Batuhan Taskaya]

Batuhan Taskaya  added the comment:

Thanks for your efforts Shantanu!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28002] ast.unparse can't roundtrip some f-strings

[Batuhan Taskaya]

Change by Batuhan Taskaya :


--
resolution:  -> not a bug
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28002] ast.unparse can't roundtrip some f-strings

[Batuhan Taskaya]

Batuhan Taskaya  added the comment:


New changeset 3763cc1dbdb930f67b443ceed7c44e4feb883b42 by Miss Islington (bot) 
in branch '3.9':
bpo-28002: Roundtrip f-strings with ast.unparse better (GH-19612) (GH-23430)
https://github.com/python/cpython/commit/3763cc1dbdb930f67b443ceed7c44e4feb883b42


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28002] ast.unparse can't roundtrip some f-strings

[Batuhan Taskaya]

Batuhan Taskaya  added the comment:


New changeset a993e901ebe60c38d46ecb31f771d0b4a206828c by Shantanu in branch 
'master':
bpo-28002: Roundtrip f-strings with ast.unparse better (#19612)
https://github.com/python/cpython/commit/a993e901ebe60c38d46ecb31f771d0b4a206828c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28002] ast.unparse can't roundtrip some f-strings

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 9.0 -> 10.0
pull_requests: +22321
pull_request: https://github.com/python/cpython/pull/23430

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28002] ast.unparse can't roundtrip some f-strings

[Shantanu]

Shantanu  added the comment:

Bumping again!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28002] ast.unparse can't roundtrip some f-strings

[Shantanu]

Shantanu  added the comment:

Just bumping this issue, as per dev guide, since 
https://github.com/python/cpython/pull/19612 has been ready for about two 
months. Would be grateful for review :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28002] ast.unparse can't roundtrip some f-strings

[Shantanu]

Change by Shantanu :


--
keywords: +patch
pull_requests: +18946
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/19612

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28002] ast.unparse can't roundtrip some f-strings

[Simon Percivall]

Simon Percivall  added the comment:

Any and all code from astunparse is certainly available for inclusion. Go ahead.

--
nosy: +simon.percivall

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28002] ast.unparse can't roundtrip some f-strings

[Batuhan Taskaya]

Batuhan Taskaya  added the comment:

> If that sounds good, I can submit a PR and inform the original author

I can't say anything before seeing the approach but fixing the problem 
definitely sounds good.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28002] ast.unparse can't roundtrip some f-strings

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28002] ast.unparse can't roundtrip some f-strings

[Shantanu]

Shantanu  added the comment:

Now that `ast.unparse` is being added to stdlib, I thought I'd bump this 
thread. The third party library `astunparse` (which attempts to support 
multiple Python versions while staying very close to Tools/parser/unparse.py) 
has an implementation that works for complex cases.
If that sounds good, I can submit a PR and inform the original author 
(astunparse is license is based on PSF's, so should be okay if the original 
author doesn't respond).

https://github.com/simonpercivall/astunparse/blob/master/lib/astunparse/unparser.py#L461

--
nosy: +hauntsaninja

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28002] ast.unparse can't roundtrip some f-strings

[Batuhan]

Change by Batuhan :


--
components: +Library (Lib) -Demos and Tools
title: Some f-strings do not round trip through Tools/parser/test_unparse.py -> 
ast.unparse can't roundtrip some f-strings
versions: +Python 3.9 -Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com