[issue28061] Compact dict bug on Windows (Visual Studio): if (mp->ma_keys->dk_usable * 3 < other->ma_used * 2)

[STINNER Victor]

STINNER Victor added the comment:

> I actually did a clean rebuild and could not reproduce, so I'm guessing 
> something did go wrong on my side.

Don't worry. It shouldn't hurt to double or tiple check. I'm not fully 
confident of this critical change (compact dict). It's good to get any kind of 
feedback ;-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28061] Compact dict bug on Windows (Visual Studio): if (mp->ma_keys->dk_usable * 3 < other->ma_used * 2)

[Emanuel Barry]

Emanuel Barry added the comment:

I actually did a clean rebuild and could not reproduce, so I'm guessing 
something did go wrong on my side.

--
priority: deferred blocker -> normal
resolution:  -> not a bug
stage: needs patch -> resolved
status: open -> closed
type: crash -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28061] Compact dict bug on Windows (Visual Studio): if (mp->ma_keys->dk_usable * 3 < other->ma_used * 2)

[STINNER Victor]

STINNER Victor added the comment:

I compiled Python in 4 modes:

* debug/32 bits
* debug/64 bits
* release/32 bits
* release/64 bits

Compilation never fails and test_dict always pass.

I'm unable to reproduce the issue, so I removed the "release blocker" flag to 
not stress our release manager :-)

--
priority: release blocker -> deferred blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28061] Compact dict bug on Windows (Visual Studio): if (mp->ma_keys->dk_usable * 3 < other->ma_used * 2)

[STINNER Victor]

STINNER Victor added the comment:

I just rebuilt the default Python branch (rev c8851a0ce7ca) on Windows in debug 
mode and 32-bit: the compilation succeeded and test_dict pass.

* Windows 8.1 (Version 6.3, Build 9600)
* Visual Studio 2015 : version 14.0.23107.0 D14EL


> It's unlikely, but we also print out the UCRT version at the end of the build 
> process (with a warning if you need to update the WinSDK).

Ah, UCRT seems outdated on my PC:

29>-- Rebuild All started: Project: _testbuffer, Configuration: Debug Win32 
--
27>  Generating Code...
26>  C:\Windows\SYSTEM32\ucrtbased.dll is version 10.0.10150.0
26>  WARN: ucrtbased contains known issues. Please update the Windows 10 SDK.
26>  See:
26>http://bugs.python.org/issue27705
26>https://developer.microsoft.com/en-US/windows/downloads/windows-10-sdk

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28061] Compact dict bug on Windows (Visual Studio): if (mp->ma_keys->dk_usable * 3 < other->ma_used * 2)

[Emanuel Barry]

Emanuel Barry added the comment:

I don't know what exactly happened that would make it crash, but after wiping 
off everything and starting over, it works fine now. Sorry for the noise!

--
components:  -Windows
priority: release blocker -> normal
resolution:  -> not a bug
stage: needs patch -> resolved
status: open -> closed
type: crash -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28061] Compact dict bug on Windows (Visual Studio): if (mp->ma_keys->dk_usable * 3 < other->ma_used * 2)

[Steve Dower]

Steve Dower added the comment:

It's unlikely, but we also print out the UCRT version at the end of the build 
process (with a warning if you need to update the WinSDK).

I built and tested a number of times with this change though. If suggest hg 
purge and rebuild to make sure everything is clean.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28061] Compact dict bug on Windows (Visual Studio): if (mp->ma_keys->dk_usable * 3 < other->ma_used * 2)

[Emanuel Barry]

Emanuel Barry added the comment:

Huh, weird. I'm running a win32 build on a 64 bits machine, with VS2015. I 
didn't have time to test on a clean checkout, I will do that first thing when 
I'm back home tonight. I hope I did something wrong and there really isn't any 
issue :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28061] Compact dict bug on Windows (Visual Studio): if (mp->ma_keys->dk_usable * 3 < other->ma_used * 2)

[INADA Naoki]

INADA Naoki added the comment:

amd64 result

c:\Users\inada-n\work\cpython>PCbuild\amd64\python_d.exe -m test.test_dict
..
--
Ran 78 tests in 1.498s

OK

c:\Users\inada-n\work\cpython>PCbuild\amd64\python_d.exe
Python 3.6.0a4+ (default, Sep 11 2016, 19:10:48) [MSC v.1900 64 bit (AMD64)] on 
win32
Type "help", "copyright", "credits" or "license" for more information.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28061] Compact dict bug on Windows (Visual Studio): if (mp->ma_keys->dk_usable * 3 < other->ma_used * 2)

[INADA Naoki]

INADA Naoki added the comment:

I noticed I tested win32 mode.  I'll rebuild on amd64 mode.

> Oh, same questions for you Naoki in fact :-)

I don't know about how to describe exist version of my Windows environment. Is 
these enough?

Windows 10 Home (with Anniversary Update)
10.0.14393 build 14393

Microsoft Visual Studio Community 2015
Version 14.0.25425.01 Update 3
Microsoft .NET Framework
Version 4.6.01586
Installed Version: Community
Microsoft Visual C++ 2015


>cl /?
Microsoft (R) C/C++ Optimizing Compiler Version 19.00.24213.1 for x86

C:\Users\inada-n\work\cpython>PCbuild\win32\python_d.exe
Python 3.6.0a4+ (default, Sep 11 2016, 18:22:14) [MSC v.1900 32 bit (Intel)] on 
win32

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28061] Compact dict bug on Windows (Visual Studio): if (mp->ma_keys->dk_usable * 3 < other->ma_used * 2)

[STINNER Victor]

STINNER Victor added the comment:

> Emanuel Barry: What is your Visual Studio (exact) version? I know that there 
> are service packs for VS. What is your Windows version?

Oh, same questions for you Naoki in fact :-) It may help to check if
it's related to VS, Windows or if it's something else.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28061] Compact dict bug on Windows (Visual Studio): if (mp->ma_keys->dk_usable * 3 < other->ma_used * 2)

[STINNER Victor]

STINNER Victor added the comment:

Emanuel Barry: What is your Visual Studio (exact) version? I know that there 
are service packs for VS. What is your Windows version?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28061] Compact dict bug on Windows (Visual Studio): if (mp->ma_keys->dk_usable * 3 < other->ma_used * 2)

[INADA Naoki]

INADA Naoki added the comment:

I built acfe53a (git hash).  Then:

c:\Users\inada-n\work\cpython>PCbuild\win32\python_d.exe -m test.test_dict
..
--
Ran 78 tests in 1.262s

OK

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28061] Compact dict bug on Windows (Visual Studio): if (mp->ma_keys->dk_usable * 3 < other->ma_used * 2)

[STINNER Victor]

Changes by STINNER Victor :


--
title: Python crashes on 'from test import support' -> Compact dict bug on 
Windows (Visual Studio): if (mp->ma_keys->dk_usable * 3 < other->ma_used * 2)

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com