[issue28115] Use argparse for the zipfile module

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Opened issue29958 for the latter patch.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28115] Use argparse for the zipfile module

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
pull_requests:  -1102

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28115] Use argparse for the zipfile module

[Donald Stufft]

Changes by Donald Stufft :


--
pull_requests: +1102

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28115] Use argparse for the zipfile module

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

SilentGhost suggested to pass required=True to add_mutually_exclusive_group(). 
This makes the last "else" not needed.

Proposed patch implements this suggestion.

--
assignee:  -> serhiy.storchaka
Added file: http://bugs.python.org/file45316/zipfile-cli-required.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28115] Use argparse for the zipfile module

[Roundup Robot]

Roundup Robot added the comment:

New changeset 7f01d9d471e5 by Serhiy Storchaka in branch '2.7':
Issue #28115: ZIP creation test requires zlib.
https://hg.python.org/cpython/rev/7f01d9d471e5

New changeset 7701e9cb8712 by Serhiy Storchaka in branch '3.5':
Issue #28115: ZIP creation test requires zlib.
https://hg.python.org/cpython/rev/7701e9cb8712

New changeset 5b779441d03e by Serhiy Storchaka in branch '3.6':
Issue #28115: ZIP creation test requires zlib.
https://hg.python.org/cpython/rev/5b779441d03e

New changeset 3e7da46aead3 by Serhiy Storchaka in branch 'default':
Issue #28115: ZIP creation test requires zlib.
https://hg.python.org/cpython/rev/3e7da46aead3

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28115] Use argparse for the zipfile module

[Roundup Robot]

Roundup Robot added the comment:

New changeset fa275e570d52 by Serhiy Storchaka in branch 'default':
Issue #28115: Command-line interface of the zipfile module now uses argparse.
https://hg.python.org/cpython/rev/fa275e570d52

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28115] Use argparse for the zipfile module

[Roundup Robot]

Roundup Robot added the comment:

New changeset 042c923c5b67 by Serhiy Storchaka in branch '2.7':
Issue #28115: Added tests for CLI of the zipfile module.
https://hg.python.org/cpython/rev/042c923c5b67

New changeset 900c47c98711 by Serhiy Storchaka in branch '3.5':
Issue #28115: Added tests for CLI of the zipfile module.
https://hg.python.org/cpython/rev/900c47c98711

New changeset a1975621bba2 by Serhiy Storchaka in branch '3.6':
Issue #28115: Added tests for CLI of the zipfile module.
https://hg.python.org/cpython/rev/a1975621bba2

New changeset 5edac3b55130 by Serhiy Storchaka in branch 'default':
Issue #28115: Added tests for CLI of the zipfile module.
https://hg.python.org/cpython/rev/5edac3b55130

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28115] Use argparse for the zipfile module

[Wolfgang Maier]

Changes by Wolfgang Maier :


--
nosy: +wolma

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28115] Use argparse for the zipfile module

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Proposed patch makes zipfile using argparse and adds tests for zipfile CLI. 
Originally it is based on tarfile code and tests (but reworked, especially 
tests). Basically the interface is not changed, but added support of long 
options, and exit code in case of calling without options is changed from 1 to 
2 (the same as wrong option is specified). The format of help and usage info is 
changed of course.

Tests are passed with old releases of Python (except supporting long options). 
They will be backported.

--
Added file: http://bugs.python.org/file45117/zipfile_argparse.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28115] Use argparse for the zipfile module

[SilentGhost]

SilentGhost added the comment:

Jaysinh, you can upload your modified patch, so it can be reviewed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28115] Use argparse for the zipfile module

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28115] Use argparse for the zipfile module

[Jaysinh shukla]

Jaysinh shukla added the comment:

@SilentGhost I have mad few comments on your patch. Please contact me on any 
confusions. Looking forward to you. Thanks!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28115] Use argparse for the zipfile module

[SilentGhost]

SilentGhost added the comment:

Neither of those fit under definition of "permissible" modules. So, I would 
then suggest to close this issue and any further issues against CLI of those 
modules.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28115] Use argparse for the zipfile module

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

They should be added. Otherwise we can't know that the code works as expected. 
You can use test_calendar.py or test_tarfile.py as a guide.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28115] Use argparse for the zipfile module

[SilentGhost]

SilentGhost added the comment:

Given that at present zipfile CLI has no test or docs, and along with Guido's 
aversion for such tools in general, I'm not at all sure they should be added. 
In any case, here is the patch for the main part of conversion.

--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file44735/28115_2.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28115] Use argparse for the zipfile module

[R. David Murray]

R. David Murray added the comment:

Note that a key part of doing a translation like this is to write tests for the 
CLI, as comprehensively as possible, so that we have some assurance we didn't 
break anything in the translation.  But experience tells us that we *will* 
break something, since we have in every one of the translations to argparse 
that we've done so far :)

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28115] Use argparse for the zipfile module

[Jaysinh shukla]

Jaysinh shukla added the comment:

I'm working on this. :)

--
nosy: +jaysinh.shukla

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28115] Use argparse for the zipfile module

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

Options and arguments for zipfile CLI are manually parsed for now. Since CLI 
becomes more complex, it is worth to convert zipfile to use argparse.

--
components: Demos and Tools
keywords: easy
messages: 276191
nosy: SilentGhost, serhiy.storchaka, sjt
priority: normal
severity: normal
stage: needs patch
status: open
title: Use argparse for the zipfile module
type: enhancement
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com