[issue28194] Clean up some checks in dict implementation

2016-09-26 Thread Serhiy Storchaka 

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28194] Clean up some checks in dict implementation

2016-09-26 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset 1d41d741bb5b by Serhiy Storchaka in branch '3.6':
Issue #28194: Clean up some checks in dict implementation.
https://hg.python.org/cpython/rev/1d41d741bb5b

New changeset b83a70afca39 by Serhiy Storchaka in branch 'default':
Issue #28194: Clean up some checks in dict implementation.
https://hg.python.org/cpython/rev/b83a70afca39

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28194] Clean up some checks in dict implementation

2016-09-26 Thread Serhiy Storchaka 

Changes by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28194] Clean up some checks in dict implementation

2016-09-18 Thread Xiang Zhang 

Xiang Zhang added the comment:

Apply methane's comment, preserving the comment.

--
Added file: http://bugs.python.org/file44738/dict_clean_up_v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28194] Clean up some checks in dict implementation

2016-09-18 Thread Serhiy Storchaka 

Serhiy Storchaka added the comment:

LGTM if address methane's comment.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28194] Clean up some checks in dict implementation

2016-09-18 Thread Xiang Zhang 

New submission from Xiang Zhang:

The proposed patch cleans up some unnecessary parts in dict implementation 
especially NULL checks in lookup functions. There are four states a 
DictKeyEntry can be. Only in unused(empty) and dummy states me_key can be NULL. 
So NULL checks in used and pending states are not needed.

--
components: Interpreter Core
files: dict_clean_up.patch
keywords: patch
messages: 276875
nosy: haypo, methane, serhiy.storchaka, xiang.zhang
priority: normal
severity: normal
stage: patch review
status: open
title: Clean up some checks in dict implementation
type: enhancement
versions: Python 3.6, Python 3.7
Added file: http://bugs.python.org/file44734/dict_clean_up.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com