[issue28269] [MinGW] Can't compile Python/dynload_win.c due to static strcasecmp

2019-08-24 Thread Serhiy Storchaka 


Serhiy Storchaka  added the comment:

Thank you for your PR Minmin. It was decided to not backport it to 3.7.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28269] [MinGW] Can't compile Python/dynload_win.c due to static strcasecmp

2019-08-24 Thread miss-islington 


miss-islington  added the comment:


New changeset 920ec4b7763d64b3742d7ddd339ad11cdbec62e9 by Miss Islington (bot) 
in branch '3.8':
bpo-28269: Replace strcasecmp with system function _stricmp. (GH-13095)
https://github.com/python/cpython/commit/920ec4b7763d64b3742d7ddd339ad11cdbec62e9


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28269] [MinGW] Can't compile Python/dynload_win.c due to static strcasecmp

2019-07-13 Thread miss-islington 


Change by miss-islington :


--
pull_requests: +14537
pull_request: https://github.com/python/cpython/pull/14741

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28269] [MinGW] Can't compile Python/dynload_win.c due to static strcasecmp

2019-07-13 Thread miss-islington 


Change by miss-islington :


--
pull_requests: +14536
pull_request: https://github.com/python/cpython/pull/14740

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28269] [MinGW] Can't compile Python/dynload_win.c due to static strcasecmp

2019-07-13 Thread Serhiy Storchaka 


Serhiy Storchaka  added the comment:


New changeset 05f2d84cae4ba1ff15b7a1d0347305393f4bdcc5 by Serhiy Storchaka 
(Minmin Gong) in branch 'master':
bpo-28269: Replace strcasecmp with system function _stricmp. (GH-13095)
https://github.com/python/cpython/commit/05f2d84cae4ba1ff15b7a1d0347305393f4bdcc5


--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28269] [MinGW] Can't compile Python/dynload_win.c due to static strcasecmp

2019-05-04 Thread Minmin Gong 


Change by Minmin Gong :


--
pull_requests: +13009
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28269] [MinGW] Can't compile Python/dynload_win.c due to static strcasecmp

2016-09-30 Thread Steve Dower 

Steve Dower added the comment:

Why not replace it entirely with stricmp? Does it behave differently?

--
components: +Windows
nosy: +paul.moore, steve.dower, tim.golden, zach.ware

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28269] [MinGW] Can't compile Python/dynload_win.c due to static strcasecmp

2016-09-25 Thread Vitaly Murashev 

Changes by Vitaly Murashev :


--
type:  -> compile error

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28269] [MinGW] Can't compile Python/dynload_win.c due to static strcasecmp

2016-09-25 Thread Vitaly Murashev 

Changes by Vitaly Murashev :


Added file: http://bugs.python.org/file44809/dynload_win.c.2.7.mingw.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28269] [MinGW] Can't compile Python/dynload_win.c due to static strcasecmp

2016-09-25 Thread Vitaly Murashev 

New submission from Vitaly Murashev:

Attempt to complile Python/dynload_win.c by MinGW fails
due to static reimplementation of strcasecmp function in this file:

---
/* Case insensitive string compare, to avoid any dependencies on particular
   C RTL implementations */

static int strcasecmp (char *string1, char *string2)
{
int first, second;

do {
first  = tolower(*string1);
second = tolower(*string2);
string1++;
string2++;
} while (first && first == second);

return (first - second);
}
---

And this reimplementation clashed with native declaration of strcasecmp()
which one is a part of MinGW runtime

So suggested patch (for 3.5.2 and 2.7.12)
just disables static reimplementation of strcasecmp for MinGW

--
components: Build
files: dynload_win.c.3.5.mingw.patch
keywords: patch
messages: 277362
nosy: vmurashev
priority: normal
severity: normal
status: open
title: [MinGW] Can't compile Python/dynload_win.c due to static strcasecmp
Added file: http://bugs.python.org/file44808/dynload_win.c.3.5.mingw.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com