[issue28449] tarfile.open(mode = 'r:*', ignore_zeros = True) has 50% chance failed to open compressed tars?

[Donald Stufft]

Changes by Donald Stufft :


--
pull_requests: +1046

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28449] tarfile.open(mode = 'r:*', ignore_zeros = True) has 50% chance failed to open compressed tars?

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28449] tarfile.open(mode = 'r:*', ignore_zeros = True) has 50% chance failed to open compressed tars?

[Roundup Robot]

Roundup Robot added the comment:

New changeset f108e063e299 by Serhiy Storchaka in branch '3.5':
Issue #28449: tarfile.open() with mode "r" or "r:" now tries to open a tar
https://hg.python.org/cpython/rev/f108e063e299

New changeset e2dd0f48e643 by Serhiy Storchaka in branch '2.7':
Issue #28449: tarfile.open() with mode "r" or "r:" now tries to open a tar
https://hg.python.org/cpython/rev/e2dd0f48e643

New changeset de8e83262644 by Serhiy Storchaka in branch '3.6':
Issue #28449: tarfile.open() with mode "r" or "r:" now tries to open a tar
https://hg.python.org/cpython/rev/de8e83262644

New changeset 220c70519958 by Serhiy Storchaka in branch 'default':
Issue #28449: tarfile.open() with mode "r" or "r:" now tries to open a tar
https://hg.python.org/cpython/rev/220c70519958

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28449] tarfile.open(mode = 'r:*', ignore_zeros = True) has 50% chance failed to open compressed tars?

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Proposed patch fixes the issue.

Existing test was passed by accident -- compressed tarfiles were too short for 
false detecting.

--
keywords: +patch
nosy: +serhiy.storchaka
stage:  -> patch review
Added file: http://bugs.python.org/file45119/tarfile_ignore_zeros_auto.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28449] tarfile.open(mode = 'r:*', ignore_zeros = True) has 50% chance failed to open compressed tars?

[Roland Bogosi]

Roland Bogosi added the comment:

For anyone finding this bug through Google before it is fixed, a workaround 
could be to monkeypatch the OPEN_METH dict with an OrderedDict:

tarfile.TarFile.OPEN_METH = OrderedDict()
tarfile.TarFile.OPEN_METH['gz']  = 'gzopen'
tarfile.TarFile.OPEN_METH['bz2'] = 'bz2open'
tarfile.TarFile.OPEN_METH['xz']  = 'xzopen'
tarfile.TarFile.OPEN_METH['tar'] = 'taropen'

--
nosy: +RoliSoft

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28449] tarfile.open(mode = 'r:*', ignore_zeros = True) has 50% chance failed to open compressed tars?

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
nosy: +lars.gustaebel
versions: +Python 2.7, Python 3.6, Python 3.7 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28449] tarfile.open(mode = 'r:*', ignore_zeros = True) has 50% chance failed to open compressed tars?

[Silver Fox]

New submission from Silver Fox:

Seems all `tarfile.open` will try all compress method(including `raw`) in 
random order, and `ignore_zeros` also hide the error during detecting compress 
method. So `raw` is used if tested before the rigth compress method, which is 
wrong.

But there is no warning that the 2 args can not be used together in docs.

--
components: Library (Lib)
messages: 278711
nosy: Silver Fox
priority: normal
severity: normal
status: open
title: tarfile.open(mode = 'r:*', ignore_zeros = True) has 50% chance failed to 
open compressed tars?
type: behavior
versions: Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com