[issue28488] shutil.make_archive (xxx, zip, root_dir) is adding './' entry to archive which is wrong

[Hinayf Wikileakean]

Hinayf Wikileakean  added the comment:

There is a similar bug/issue for 'tar' archives.

--
nosy: +Hinayf Wikileakean

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28488] shutil.make_archive (xxx, zip, root_dir) is adding './' entry to archive which is wrong

[Donald Stufft]

Changes by Donald Stufft :


--
pull_requests: +878

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28488] shutil.make_archive (xxx, zip, root_dir) is adding './' entry to archive which is wrong

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28488] shutil.make_archive (xxx, zip, root_dir) is adding './' entry to archive which is wrong

[Roundup Robot]

Roundup Robot added the comment:

New changeset 847537b7924c by Serhiy Storchaka in branch '2.7':
Issue #28488: shutil.make_archive() no longer adds entry "./" to ZIP archive.
https://hg.python.org/cpython/rev/847537b7924c

New changeset d4fce66ebe01 by Serhiy Storchaka in branch '3.5':
Issue #28488: shutil.make_archive() no longer adds entry "./" to ZIP archive.
https://hg.python.org/cpython/rev/d4fce66ebe01

New changeset e93149fee04d by Serhiy Storchaka in branch '3.6':
Issue #28488: shutil.make_archive() no longer adds entry "./" to ZIP archive.
https://hg.python.org/cpython/rev/e93149fee04d

New changeset 72da53d3074b by Serhiy Storchaka in branch 'default':
Issue #28488: shutil.make_archive() no longer adds entry "./" to ZIP archive.
https://hg.python.org/cpython/rev/72da53d3074b

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28488] shutil.make_archive (xxx, zip, root_dir) is adding './' entry to archive which is wrong

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you for your report Alexander. Yes, this regression was introduced in 
issue24982. Proposed patch fixes it.

--
assignee:  -> serhiy.storchaka
keywords: +patch
stage: needs patch -> patch review
Added file: 
http://bugs.python.org/file45153/shutil_make_archive_zip_curdir.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28488] shutil.make_archive (xxx, zip, root_dir) is adding './' entry to archive which is wrong

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
nosy: +alanmcintyre, serhiy.storchaka, tarek, twouters
stage:  -> needs patch
type:  -> behavior
versions: +Python 3.5, Python 3.6, Python 3.7 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28488] shutil.make_archive (xxx, zip, root_dir) is adding './' entry to archive which is wrong

[Alexander Belchenko]

New submission from Alexander Belchenko:

Running shutil.make_archive('a', 'zip', 'subdir') is created wrong and not 
really needed entry "./" which is visible in zipfile.ZipFile.namelist():

['./', 'foo/', 'hello.txt', 'foo/bar.txt']

This "./" affects some (windows) unzip tools which produces warnings/errors 
about this incorrect entry.

This error present in Python 2.7.11-12 and Python 3.4.4 (those I have installed 
right now). But Python 3.3.5 does not have it, maybe because it omits entries 
for directories at all.

I've attached a simple script which illustrates problem. Tested on Windows with 
mentioned python versions.

Can't reproduce on Centos 7.2 with Python 3.4.3 and 2.7.5.

I suppose it could be realted to the change I spot in latest 2.7 changelog:

- Issue #24982: shutil.make_archive() with the "zip" format now adds entries
  for directories (including empty directories) in ZIP file.

--
components: Library (Lib)
files: make-archive-test.py
messages: 279031
nosy: bialix
priority: normal
severity: normal
status: open
title: shutil.make_archive (xxx, zip, root_dir) is adding './' entry to archive 
which is wrong
versions: Python 2.7, Python 3.4
Added file: http://bugs.python.org/file45151/make-archive-test.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com