[issue28584] ICC compiler check is too permissive

[Ben Boeckel]

Change by Ben Boeckel :


--
nosy: +mathstuf

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28584] ICC compiler check is too permissive

[Irit Katriel]

Irit Katriel  added the comment:

Closed issue44832 as a duplicate of this.

--
nosy: +iritkatriel

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28584] ICC compiler check is too permissive

[Zachary Ware]

Change by Zachary Ware :


--
versions: +Python 3.10, Python 3.11, Python 3.9 -Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28584] ICC compiler check is too permissive

[STINNER Victor]

Change by STINNER Victor :


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28584] ICC compiler check is too permissive

[Gianfranco]

Gianfranco  added the comment:

My first attempt was instead of
*gcc*
to just check for
*gcc

this avoids when "icc" is the last part of the string, I admit this is not too 
strong.
Another approach is to use basename with cut -d " " -f 1 to pick just the first 
parameter, but maybe the best way is to do something like this:
gcc|*/gcc|*-gcc

I confirm the "icc-find-v2.patch" works in this way

--
Added file: https://bugs.python.org/file47597/icc-find-v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28584] ICC compiler check is too permissive

[Gianfranco]

Gianfranco  added the comment:

I'm attaching the patch that works also for parameters, e.g. when CC contains 
--sysroot=/home/icc or similar.
we can mark https://bugs.python.org/issue33341 duplicate to this one I think

--
nosy: +locutusofborg
versions: +Python 3.8 -Python 2.7, Python 3.5, Python 3.6, Python 3.7
Added file: https://bugs.python.org/file47595/icc-find.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28584] ICC compiler check is too permissive

[Josh Rosenberg]

Josh Rosenberg added the comment:

It's probably bad form, but I've seen people set CC to name/path to compiler 
followed by switches, e.g.:

   export CC='gcc -march=native -O3'

or the like (usually because they want to keep the build tool's default CFLAGS, 
and setting CFLAGS causes them to be replaced, not supplemented).

basename seems to strip the leading path components, but if someone shoved in 
other switches, they aren't removed, so if they happen to have "icc" in them, 
this would still have issues. Perhaps a basename followed by splitting on 
whitespace and only keeping the first component? Not a configure expert, not 
sure what's possible.

--
nosy: +josh.r

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28584] ICC compiler check is too permissive

[Zachary Ware]

Changes by Zachary Ware :


--
nosy: +zach.ware
stage:  -> patch review
versions:  -Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28584] ICC compiler check is too permissive

[Carmelo Piccione]

Changes by Carmelo Piccione :


--
versions: +Python 2.7, Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28584] ICC compiler check is too permissive

[Carmelo Piccione]

New submission from Carmelo Piccione:

if the ${CC} variable has an encoded path which contains "icc" anywhere in the 
string, it will be interpreted by the configure script as an icc compiler 
rather than gcc. This is due to matching on *icc* in various places.

Example: "/home/cpiccion/.linuxbrew/bin/gcc" will match because of the 
"cpiccion".

This is also true for the other patterns, including "gcc".

Proposed fix is to take the basename of the ${CC} variable first.

--
components: Installation
files: icc-pattern-check-fix.patch
keywords: patch
messages: 279893
nosy: struktured
priority: normal
severity: normal
status: open
title: ICC compiler check is too permissive
type: compile error
versions: Python 3.5, Python 3.6, Python 3.7
Added file: http://bugs.python.org/file45307/icc-pattern-check-fix.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com