[issue28707] add 'directory' option to the http.server module

[STINNER Victor]

Changes by STINNER Victor :


--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28707] add 'directory' option to the http.server module

[STINNER Victor]

STINNER Victor added the comment:

Patch merged. Thanks Stéphane and Julien! Especially because writing the unit 
test was much more painful than I expected, but it's really worth it!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28707] add 'directory' option to the http.server module

[STINNER Victor]

STINNER Victor added the comment:


New changeset a17a2f52c4c3b37414da95a152fc8669978c7c83 by Victor Stinner 
(Stéphane Wirtel) in branch 'master':
bpo-28707: Add the directory parameter to http.server.SimpleHTTPRequestHandler 
and http.server module (#1776)
https://github.com/python/cpython/commit/a17a2f52c4c3b37414da95a152fc8669978c7c83


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28707] add 'directory' option to the http.server module

[STINNER Victor]

STINNER Victor added the comment:

Stéphane Wirtel added the comment:

and of course, sorry for this big delay.

I am not sure why you are saying that. Nobody was actively awaiting on this
feature, we all have busy scedules. It's ok ;-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28707] add 'directory' option to the http.server module

[Stéphane Wirtel]

Stéphane Wirtel added the comment:

and of course, sorry for this big delay.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28707] add 'directory' option to the http.server module

[Stéphane Wirtel]

Stéphane Wirtel added the comment:

Victor,

I have added the documentation, but for the unit test, there is already a test 
with the SimpleHTTPRequestHandler class where they specify the cwd attribute, 
because the code of mdk does not change the behavior, I think it's not needed 
to write a test.

now, if you think we need a test for this specific case (in fact we only 
override the constructor of the class and specify the directory parameter), I 
can write a test, but check the code before.

Thank you.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28707] add 'directory' option to the http.server module

[Stéphane Wirtel]

Changes by Stéphane Wirtel :


--
pull_requests: +1856

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28707] add 'directory' option to the http.server module

[Julien Palard]

Changes by Julien Palard :


Added file: http://bugs.python.org/file45764/issue28707.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28707] add 'directory' option to the http.server module

[Julien Palard]

Julien Palard added the comment:

@Victor you're right, I forgot that partial can also apply keyword arguments. 
Here is a new patch.

--
Added file: http://bugs.python.org/file45753/issue28707.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28707] add 'directory' option to the http.server module

[Xiang Zhang]

Xiang Zhang added the comment:

+1 for this idea. I use this command everyday in work and every time must cd to 
the directory is an annoyance.

--
nosy: +xiang.zhang

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28707] add 'directory' option to the http.server module

[STINNER Victor]

STINNER Victor added the comment:

Julien Palard added the comment:
> If we were able to pass an instance of SimpleHTTPRequestHandler instead of 
> its class, we'd be able to give the `directory` to the handler during the 
> `main()`, instead of using with `chdir` and `getcwd` to pass the information 
> in a kind of hidden/side channel.

You may be able to use functools.partial() to pass an additional
parameter to the request handler constructor.

We use something like that in asyncio for protocols.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28707] add 'directory' option to the http.server module

[Julien Palard]

Julien Palard added the comment:

Hi Stéphane,

Your patch is simple and elegant, but I'm asking myself a question about the 
idea to pass a class instead of an instance to the TCPServer ctor (I know 
that's not your choice).

If we were able to pass an instance of SimpleHTTPRequestHandler instead of its 
class, we'd be able to give the `directory` to the handler during the `main()`, 
instead of using with `chdir` and `getcwd` to pass the information in a kind of 
hidden/side channel.

I think that relying on `chdir` and `getcwd` to pass a parameter is not the 
most pretty or most testable way to do so. Also, having an `os.getcwd()` 
hardcoded in `SimpleHTTPRequestHandler` does not looks right (again, not your 
fault, it was here before…) typically for testability, but also when used in a 
concurrent environment, when cwd may be changed by other "coroutines".

I tried to provide a patch fixing all those condiderations, here it is. still, 
I can't write a patch as KISS as yours, so I'm probably in the wrong way, at 
least I tried.

--
nosy: +mdk
Added file: http://bugs.python.org/file45494/28707.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28707] add 'directory' option to the http.server module

[STINNER Victor]

STINNER Victor added the comment:

The new feature should be documented in Doc/library/http.server.rst, and maybe 
also Doc/whatsnew/3.7.rst.

Is it possible to write an unit test?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28707] add 'directory' option to the http.server module

[Stéphane Wirtel]

Changes by Stéphane Wirtel :


--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28707] add 'directory' option to the http.server module

[Stéphane Wirtel]

New submission from Stéphane Wirtel:

When we execute the http.server module, the tool will use the current directory 
(os.getcwd()) but sometimes we would like to specify a directory on the command 
line. 

With the next patch, I try to fix this missing feature ;-)

Just with python -m http.server -d /tmp

by default the system will use the current directory.
if necessary, I will show an error if the directory does not exist.

--
files: chdir-httpserver.diff
keywords: patch
messages: 280898
nosy: matrixise
priority: normal
severity: normal
status: open
title: add 'directory' option to the http.server module
versions: Python 3.6, Python 3.7
Added file: http://bugs.python.org/file45493/chdir-httpserver.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com