[issue28746] cannot set_inheritable() for a file descriptor on Android

[Donald Stufft]

Changes by Donald Stufft :


--
pull_requests: +860

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28746] cannot set_inheritable() for a file descriptor on Android

[Xavier de Gaye]

Changes by Xavier de Gaye :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28746] cannot set_inheritable() for a file descriptor on Android

[Roundup Robot]

Roundup Robot added the comment:

New changeset 2fb2e3dc450e by Xavier de Gaye in branch '3.6':
Issue #28746: Fix the set_inheritable() file descriptor method on platforms
https://hg.python.org/cpython/rev/2fb2e3dc450e

New changeset 3248782c3176 by Xavier de Gaye in branch 'default':
Issue #28746: Merge 3.6
https://hg.python.org/cpython/rev/3248782c3176

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28746] cannot set_inheritable() for a file descriptor on Android

[Xavier de Gaye]

Xavier de Gaye added the comment:

It seems the code path run by Android is not tested by any of the buildbots.
Patch attached.

--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file45547/set_inheritable.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28746] cannot set_inheritable() for a file descriptor on Android

[Xavier de Gaye]

New submission from Xavier de Gaye:

test_socket on Android fails with:
FAIL: test_set_inheritable (test.test_socket.InheritanceTest)
--
Traceback (most recent call last):
  File "/sdcard/org.bitbucket.pyona/lib/python3.7/test/test_socket.py", line 
4936, in test_set_inheritable
self.assertEqual(sock.get_inheritable(), True)
AssertionError: False != True

==
FAIL: test_set_inheritable_cloexec (test.test_socket.InheritanceTest)
--
Traceback (most recent call last):
  File "/sdcard/org.bitbucket.pyona/lib/python3.7/test/test_socket.py", line 
4965, in test_set_inheritable_cloexec
0)
AssertionError: 1 != 0

Setting a file descriptor with os.set_inheritable() also fails.
Setting directly the file descriptor with fcntl.fcntl() succeeds.

--
assignee: xdegaye
components: Interpreter Core
messages: 281221
nosy: xdegaye
priority: normal
severity: normal
stage: needs patch
status: open
title: cannot set_inheritable() for a file descriptor on Android
type: behavior
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com