[issue28753] Clinic: Converting Your First Function is not up to date

2016-12-11 Thread Julien Palard 

Changes by Julien Palard :


--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28753] Clinic: Converting Your First Function is not up to date

2016-12-09 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset 7a93d1a0a1cf by Martin Panter in branch '3.5':
Issue 28753: Argument Clinic howto docfix, courtesy Julien Palard.
https://hg.python.org/cpython/rev/7a93d1a0a1cf

New changeset d0859a11322c by Martin Panter in branch '3.6':
Issues #28755, #28753: Merge Arg Clinic howto from 3.5
https://hg.python.org/cpython/rev/d0859a11322c

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28753] Clinic: Converting Your First Function is not up to date

2016-11-25 Thread STINNER Victor 

STINNER Victor added the comment:

issue28753.fastcall.diff LGTM.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28753] Clinic: Converting Your First Function is not up to date

2016-11-24 Thread Julien Palard 

Julien Palard added the comment:

After a discussion with Victor, I propose a patch to update the documentation 
allowing users strictly following the doc to let Clinic use FASTCALLs, it's a 
nice performance gain, and it's safe to let clinic use it.

--
Added file: http://bugs.python.org/file45630/issue28753.fastcall.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28753] Clinic: Converting Your First Function is not up to date

2016-11-23 Thread Julien Palard 

Julien Palard added the comment:

Reopening to remind @Victor we have a question about METH_FASTCALL.

--
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28753] Clinic: Converting Your First Function is not up to date

2016-11-20 Thread Larry Hastings 

Larry Hastings added the comment:

Let's see what Victor has to say.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28753] Clinic: Converting Your First Function is not up to date

2016-11-20 Thread Julien Palard 

Julien Palard added the comment:

Should we keep this open for the FASTCALL bit?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28753] Clinic: Converting Your First Function is not up to date

2016-11-20 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset 0a18d2cfeb52 by Larry Hastings in branch 'default':
Issue 28753: Argument Clinic howto docfix, courtesy Julien Palard.
https://hg.python.org/cpython/rev/0a18d2cfeb52

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28753] Clinic: Converting Your First Function is not up to date

2016-11-20 Thread Larry Hastings 

Changes by Larry Hastings :


--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28753] Clinic: Converting Your First Function is not up to date

2016-11-20 Thread Julien Palard 

Julien Palard added the comment:

Thanks for proof-reading my english, your editions are really nice: LGTM.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28753] Clinic: Converting Your First Function is not up to date

2016-11-20 Thread Larry Hastings 

Larry Hastings added the comment:

I understand your concern as a non-English speaker, but your patch was really 
pretty good.  I did edit it a little; how's this?

--
Added file: http://bugs.python.org/file45566/larry.issue28753.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28753] Clinic: Converting Your First Function is not up to date

2016-11-20 Thread Julien Palard 

Julien Palard added the comment:

@Larry: As a french-speaking guy, I typically don't write non-internal doc in 
english, fearing it sound weird for natives. I prefer translating it back in 
french (I'm the current leader of https://github.com/afpy/python_doc_fr)

Here, here is a patch.

--
keywords: +patch
Added file: http://bugs.python.org/file45565/issue28753.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28753] Clinic: Converting Your First Function is not up to date

2016-11-20 Thread Larry Hastings 

Larry Hastings added the comment:

The bit about the "clinic/_" include is a good point.  Care to write a doc 
patch?

The bit about FASTCALL I don't know anything about because I haven't worked 
with FASTCALL.  I've added Victor Stinner, the author of the FASTCALL patch, 
maybe he can address your concerns about FASTCALL.

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28753] Clinic: Converting Your First Function is not up to date

2016-11-20 Thread Julien Palard 

Changes by Julien Palard :


--
assignee:  -> docs@python
components: +Documentation
nosy: +docs@python
type:  -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28753] Clinic: Converting Your First Function is not up to date

2016-11-20 Thread Julien Palard 

Changes by Julien Palard :


--
components: +Argument Clinic
nosy: +larry
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28753] Clinic: Converting Your First Function is not up to date

2016-11-20 Thread Julien Palard 

Changes by Julien Palard :


--
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28753] Clinic: Converting Your First Function is not up to date

2016-11-20 Thread Julien Palard 

New submission from Julien Palard:

It looks like the "Converting Your First Function" has been written with 
clinic-generated C code interspersed with user C code. But it looks like 
nowadays a `clinic/{}.c.h` file is generated, so the "Converting Your First 
Function" should tell us to add the `#include "clinic/…`.

Also, the documentation states:

> If any of these items differ in any way, adjust your Argument
> Clinic function specification and rerun Tools/clinic/clinic.py
> until they are the same.

But since `METH_FASTCALL` it may be wrong (Clinic generated `METH_FASTCALL` but 
it was `METH_VARARGS|METH_KEYWORDS`).

--
messages: 281281
nosy: mdk
priority: normal
severity: normal
status: open
title: Clinic: Converting Your First Function is not up to date

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com