[issue28774] Better start and end position for unicodeerror in unicode_encode_ucs1

[Donald Stufft]

Changes by Donald Stufft :


--
pull_requests: +1024

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28774] Better start and end position for unicodeerror in unicode_encode_ucs1

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28774] Better start and end position for unicodeerror in unicode_encode_ucs1

[Roundup Robot]

Roundup Robot added the comment:

New changeset 3addf93f4111 by Serhiy Storchaka in branch 'default':
Issue #28774: Simplified encoding a str result of an error handler in ASCII
https://hg.python.org/cpython/rev/3addf93f4111

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28774] Better start and end position for unicodeerror in unicode_encode_ucs1

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Congratulations, Xiang!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28774] Better start and end position for unicodeerror in unicode_encode_ucs1

[Xiang Zhang]

Xiang Zhang added the comment:

Thanks Serhiy and Victor. Finished my first commit. :-)

Now assign back to Serhiy and pos2 LGTM.

--
assignee: xiang.zhang -> serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28774] Better start and end position for unicodeerror in unicode_encode_ucs1

[Roundup Robot]

Roundup Robot added the comment:

New changeset 3d660ed2a60e by Xiang Zhang in branch 'default':
Issue #28774: Fix start/end pos in unicode_encode_ucs1().
https://hg.python.org/cpython/rev/3d660ed2a60e

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28774] Better start and end position for unicodeerror in unicode_encode_ucs1

[STINNER Victor]

STINNER Victor added the comment:

> No need to backport it to 3.6 (if I didn't miss something).

Sorry, I misunderstood the issue. It's an enhancement, so for 3.7 only.

Right, 3.6 is now almost frozen, only major bug fixes blocking the release are 
accepted now (in short). Regular bugfixes should wait for 3.6.1.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28774] Better start and end position for unicodeerror in unicode_encode_ucs1

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

This is not a bug itself. It seems to me that at worst case the current code is 
less efficient with non-standard error handler than it can be. I would commit 
the path to the 3.6 branch before beta 4 as it is nice and simple additional to 
already added optimization. But it is too late now, at last beta.

Xiang can commit his patch to 3.7. No need to backport it to 3.6 (if I didn't 
miss something).

--
assignee: serhiy.storchaka -> xiang.zhang
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28774] Better start and end position for unicodeerror in unicode_encode_ucs1

[STINNER Victor]

STINNER Victor added the comment:

> LGTM. But it is too late for beta 4. I'll commit the patch either after 
> releasing 3.6.0 or in the 3.7 branch only.

Right now, I suggest to only commit into 3.7. Such minor bug can wait for 
Python 3.6.1.


> And while we are here I noticed that handling non-ASCII replacement string 
> could be simpler

I also suggest to first commit unicode_encode_ucs1_error_pos.patch and then 
commit the other part of unicode_encode_ucs1_error_pos2.patch in a separated 
commit. I will be easy to backport the fix to the 3.6 branch later.

Serhiy: Xiang became a core developer, are you ok if he push himself  
unicode_encode_ucs1_error_pos.patch to default tomorrow, and later you rebase 
your patch on top of that?

I'm not super confident because the fix doesn't come with an unit test, but 
it's ok if Serhiy reviewed it :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28774] Better start and end position for unicodeerror in unicode_encode_ucs1

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

LGTM. But it is too late for beta 4. I'll commit the patch either after 
releasing 3.6.0 or in the 3.7 branch only.

And while we are here I noticed that handling non-ASCII replacement string 
could be simpler.

--
Added file: 
http://bugs.python.org/file45603/unicode_encode_ucs1_error_pos2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28774] Better start and end position for unicodeerror in unicode_encode_ucs1

[STINNER Victor]

Changes by STINNER Victor :


--
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28774] Better start and end position for unicodeerror in unicode_encode_ucs1

[STINNER Victor]

STINNER Victor added the comment:

If I understood correctly, the patch fix the ASCII encoder to handle correctly 
error handlers which return non-ASCII text replacement strings. Right?

I am not aware of such error handler, so I guess that it's a more a theorical 
fix?

I really hate the code (in each encoder) which handles non-ASCII replacement 
strings. The code in the charmap encoder is just a mess: it uses a reentrant 
call to the encoder... I never understood this crazy behaviour. I guess that 
nobody relies on the behaviour. I hesitate to simply raise an error instead of 
using different rules depending on the code. Ah yes, by the way, each codec 
behaves differently on non-ASCII replacement strings...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28774] Better start and end position for unicodeerror in unicode_encode_ucs1

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka
priority: normal -> low

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28774] Better start and end position for unicodeerror in unicode_encode_ucs1

[Xiang Zhang]

New submission from Xiang Zhang:

unicode_encode_ucs1 now recognizes as many characters as it can one time 
instead of one character a time. But the unicodeerror positions still only 
count 1(the second time). A similar problem reported in #28561.

--
components: Interpreter Core
files: unicode_encode_ucs1_error_pos.patch
keywords: patch
messages: 281482
nosy: haypo, serhiy.storchaka, xiang.zhang
priority: normal
severity: normal
stage: patch review
status: open
title: Better start and end position for unicodeerror in unicode_encode_ucs1
type: enhancement
versions: Python 3.6, Python 3.7
Added file: http://bugs.python.org/file45602/unicode_encode_ucs1_error_pos.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com