[issue29040] building Android with android-ndk-r14

[Xavier de Gaye]

Change by Xavier de Gaye :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29040] building Android with android-ndk-r14

[Xavier de Gaye]

Xavier de Gaye  added the comment:


New changeset c06c22e9a9fb9326e79fcf1551601eacc1fd457d by xdegaye in branch 
'master':
bpo-29040: Support building Android with Unified Headers (GH-4492)
https://github.com/python/cpython/commit/c06c22e9a9fb9326e79fcf1551601eacc1fd457d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29040] building Android with android-ndk-r14

[Xavier de Gaye]

Change by Xavier de Gaye :


--
keywords: +patch
pull_requests: +4429
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29040] building Android with android-ndk-r14

[Xavier de Gaye]

Change by Xavier de Gaye :


--
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29040] building Android with android-ndk-r14

[Xavier de Gaye]

Xavier de Gaye added the comment:

> Seems that indicates future Python versions will require at least NDK r14 to 
> build?

Yes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29040] building Android with android-ndk-r14

[Chi Hsuan Yen]

Chi Hsuan Yen added the comment:

Thanks for compiling up necessary changes for NDK r14! Seems that indicates 
future Python versions will require at least NDK r14 to build?

Another headache from unified headers is that it requires different --sysroot 
in compilation and linking. Currently setup.py/distutils does not cope with it 
well. See my dirty hack at [1] for an ad-hoc workaround.

[1] 
https://github.com/yan12125/python3-android/blob/master/mk/python/distutils-android-sysroot.patch

--
nosy: +Chi Hsuan Yen

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29040] building Android with android-ndk-r14

[Xavier de Gaye]

New submission from Xavier de Gaye:

android-ndk-r14 introduces "Unified Headers" [1] and is planned to be released 
late january/early february 2017 [2].

__ANDROID_API__ is not anymore defined in 'android/api-level.h' that is 
currently included by Include/pyport.h, and is passed instead with 
-D__ANDROID_API__=$API when compiling. And 'android/api-level.h' is now used to 
set the API level to 1 as a Magic version number for a current development 
build when __ANDROID_API__ is not defined (see attached file).

Adoption of android-ndk-r14 should be made with the following changes:
* Remove the include of  in Include/pyport.h.
* Update configure.ac to abort when __ANDROID__ is defined and __ANDROID_API__ 
is not defined.
* Revert the changes made in issues #28538 and #28762, android-ndk-r14 fixes 
the problems raised in these two issues.

[1] 
https://android.googlesource.com/platform/ndk.git/+/master/docs/UnifiedHeaders.md
[2] https://github.com/android-ndk/ndk/wiki

--
components: Cross-Build
files: api-level.h
messages: 283778
nosy: Alex.Willmer, xdegaye
priority: normal
severity: normal
stage: needs patch
status: open
title: building Android with android-ndk-r14
type: compile error
versions: Python 3.6, Python 3.7
Added file: http://bugs.python.org/file45987/api-level.h

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com