[issue29076] Mac installer shell updater script silently fails if default shell is fish

[Ned Deily]

Ned Deily  added the comment:

Thanks for the PR!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29076] Mac installer shell updater script silently fails if default shell is fish

[Ned Deily]

Ned Deily  added the comment:


New changeset 81b23a9b148b60f8f541e4b06e1d88c58644e3b8 by Miss Islington (bot) 
in branch '3.8':
bpo-29076: Add fish support to macOS installer (GH-23302) (GH-23938)
https://github.com/python/cpython/commit/81b23a9b148b60f8f541e4b06e1d88c58644e3b8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29076] Mac installer shell updater script silently fails if default shell is fish

[Ned Deily]

Ned Deily  added the comment:


New changeset e9c6c26aff08e4c7bc6f1e8015cdd8edcc92dbef by Miss Islington (bot) 
in branch '3.9':
bpo-29076: Add fish support to macOS installer (GH-23302) (GH-23937)
https://github.com/python/cpython/commit/e9c6c26aff08e4c7bc6f1e8015cdd8edcc92dbef


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29076] Mac installer shell updater script silently fails if default shell is fish

[miss-islington]

miss-islington  added the comment:


New changeset 7f162e867c674f57c308a87fffcdcca3540c8933 by Erlend Egeberg 
Aasland in branch 'master':
bpo-29076: Add fish support to macOS installer (GH-23302)
https://github.com/python/cpython/commit/7f162e867c674f57c308a87fffcdcca3540c8933


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29076] Mac installer shell updater script silently fails if default shell is fish

[miss-islington]

Change by miss-islington :


--
pull_requests: +22788
pull_request: https://github.com/python/cpython/pull/23938

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29076] Mac installer shell updater script silently fails if default shell is fish

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 4.0 -> 5.0
pull_requests: +22787
pull_request: https://github.com/python/cpython/pull/23937

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29076] Mac installer shell updater script silently fails if default shell is fish

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


--
pull_requests: +22193
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/23302

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29076] Mac installer shell updater script silently fails if default shell is fish

[Erlend Egeberg Aasland]

Erlend Egeberg Aasland  added the comment:

Sure, I'll create a PR right away.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29076] Mac installer shell updater script silently fails if default shell is fish

[Ronald Oussoren]

Ronald Oussoren  added the comment:

@Erland: The attached patch looks fine to me. Could you convert it to a PR?

--
versions: +Python 3.10, Python 3.8, Python 3.9 -Python 2.7, Python 3.6, Python 
3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29076] Mac installer shell updater script silently fails if default shell is fish

[Erlend Egeberg Aasland]

Erlend Egeberg Aasland  added the comment:

I've created a patch that applies fine to 3.7, 3.8 and 3.9, if anyone still is 
interested.

(Backporting to 3.6 and 2.7 is probably not going to happen, but at least the 
patch applies fine to both of them.)


The "Versions" label list should probably be updated to include 3.8 and 3.9.

--
keywords: +patch
nosy: +erlendaasland
Added file: 
https://bugs.python.org/file48929/0001-bpo-29076-Add-fish-support-to-macOS-build.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29076] Mac installer shell updater script silently fails if default shell is fish

[Ned Deily]

Changes by Ned Deily :


--
stage:  -> needs patch
title: Py 3.6 Mac installer doesn't update "python3" shell command -> Mac 
installer shell updater script silently fails if default shell is fish
versions: +Python 2.7, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com