[issue2919] Merge profile/cProfile in 3.0
Changes by Eric Snow ericsnowcurren...@gmail.com: -- nosy: +eric.snow ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Changes by Éric Araujo mer...@netwok.org: -- nosy: +eric.araujo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Mark Lawrence breamore...@yahoo.co.uk added the comment: Is there anyone who could review this, it seems a shame that someone's work has been sitting in limbo for over a year? -- nosy: +BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Alexander Belopolsky belopol...@users.sourceforge.net added the comment: Is this a case of pure python implementation with a C speedup? Can you upload the patch to Rietveld? I'll take a look once it is there. -- nosy: +belopolsky ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Brett Cannon br...@python.org added the comment: Alexandre has commit privs so he could just go ahead and commit if he wants. I do hope to look at this code at some point in my life. I will see if I can't find time at EuroPython next week, especially if Alexander has fixes to it and still feels the need for a review. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Changes by Andrew Svetlov andrew.svet...@gmail.com: -- nosy: +asvetlov ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Brett Cannon br...@python.org added the comment: I'll see if I can have a look sometime soon, but my profile experience is practically non-existent so I am not the best person for a code review. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Alexandre Vassalotti alexan...@peadrop.com added the comment: Any comment about the code I posted? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Alexandre Vassalotti alexan...@peadrop.com added the comment: Here's an updated version of my lsprof.py module. I fixed a few bugs, includes the awful reference leak that was present in the previous version (i.e., the profiler code was keeping a reference to every frame executed). I consider the lsprof.py code functionally equivalent to _lsprof. Now, I am wondering if I should add the features from profile.py missing in _lsprof, e.g., the bias argument and the calibration code. -- Added file: http://bugs.python.org/file14463/lsprof.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Changes by Alexandre Vassalotti alexan...@peadrop.com: Removed file: http://bugs.python.org/file14376/lsprof.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Alexandre Vassalotti alexan...@peadrop.com added the comment: Yesterday, I ported the _lsprof module to Python as an experiment. I still have a few issues to iron out, but the core of the functionality is there. I am not sure yet how this experiment will fit in the profile/cProfile merge. I wrote the port mainly to get a better idea of what is needed for the merge and how the profiler works. -- Added file: http://bugs.python.org/file14376/lsprof.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Changes by Alexandre Vassalotti alexan...@peadrop.com: Added file: http://bugs.python.org/file14377/pyprofile.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Alexandre Vassalotti alexan...@peadrop.com added the comment: Jean Brouwers wrote: All tests passed after regenerating the expected results The tests for profile are output test. If you regenerate them, they pass for sure. Merging cProfile/profile will require a lot more work than just renaming the module. The designs of cProfile and profile are significantly different. So a successful merge will require settling one profiler design (cProfile is the better designed one, IMHO) and rewrite the other one to match the chosen design. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Changes by Jean Brouwers mrje...@gmail.com: Removed file: http://bugs.python.org/file14131/profile_module.tgz ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Jean Brouwers mrje...@gmail.com added the comment: Fixed a couple of typos in the README and _profile_hires.c files of the attached profile_module2.tgz tar ball. -- Added file: http://bugs.python.org/file14156/profile_module2.tgz ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Jean Brouwers mrje...@gmail.com added the comment: Attached is *an* attempt to combine the old profile/cProfile modules into a single one called profile. Only the C and Python source and test files are included, not any documentation files. More details are in the README file, copied below. Hopefully, this is useful. /Jean Brouwers These are the modified files to replace the old profile module with the fast cProfile one and rename the latter. A complete list and description follow. ./README ./profileNEW/setup.py ./profileNEW/Lib/profile.py ./profileNEW/Lib/test/profilee.py ./profileNEW/Lib/test/test_profile.py ./profileNEW/Modules/_profile.c ./profilePy3k/setup.py ./profilePy3k/Lib/profile.py ./profilePy3k/Lib/test/profilee.py ./profilePy3k/Lib/test/test_cprofile.py ./profilePy3k/Lib/test/test_profile.py ./profilePy3k/Modules/_lsprof.c ./diff_-u_profilePy3k_Modules_lsprof.c_profileNEW_Modules_profile.c.txt ./diff_-ur_profilePy3k_profileNEW.txt ./_profile_hires.c Directory profileNEW contains all the source and test files in their corresponding directories. Directory profilePy3k contains the old, original files from the py3k trunk taken on May 31, 2009. Basically, the old _lsprof.c file has been modified and renamed to _profile.c. Both old test_profile.py and test_cprofile.py files have been combined into a single new file test_profile.py. The file diff_-ur_profilePy3k_profileNEW.txt contains the forward diffences between all the new and orginal files. File diff_-u_profilePy3k_Modules_lsprof.c_profileNEW_Modules_profile.c.txt contains just the differences between the old _lsprof.c and new _profile.c files. Lastly, for your consideration, file _profile_hires.c is the new _profile.c file enhanced to use a high resolution timer, see http://bugs.python.org/issue2281. This file would replace the _profile.c file in the profileNEW/Modules directory. The new files and tests were installed in a Python 3.0.1 build and compiled and tested on MacOS X 10.4.11 Tiger (Intel). The patches from issue 5330 were also installed in this build, see http://bugs.python.org/issue5330. All tests passed after regenerating the expected results % python.exe Lib/test/test_profile.py -r Regenerating Lib/test/test_profile.py... % python.exe Lib/test/test_profile.py test_bad_counter_during_dealloc (__main__.ProfileTest) ... ok test_calling_conventions (__main__.ProfileTest) ... ok test_profile (__main__.ProfileTest) ... ok -- Ran 3 tests in 0.017s OK -- nosy: +MrJean1 Added file: http://bugs.python.org/file14131/profile_module.tgz ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Brett Cannon br...@python.org added the comment: Thanks for the code, Jean. With Python 3.1 about to go out the door this will have to be a 3.2 thing. But I plan to start looking at this module merge some time in July so I should get to looking at what you did then (unless someone beats me to it). -- stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Changes by Raymond Hettinger rhettin...@users.sourceforge.net: -- versions: +Python 3.2 -Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Jean Brouwers mrje...@gmail.com added the comment: I just added another comment about the high-resolution timer in http://bugs.python.org/issue2281. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Humberto Diogenes humbe...@digi.com.br added the comment: How is this going? -- nosy: +hdiogenes ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Alexandre Vassalotti [EMAIL PROTECTED] added the comment: Sorry, I can't. I would love to get this done, but I am just too busy this week (and next week doesn't look any better). Furthermore, the amount of work that the profile/cProfile merge will require is quite considerable. So, I don't expect someone else could get this done before the beta. -- keywords: +patch ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Benjamin Peterson [EMAIL PROTECTED] added the comment: Let's retarget 3.1 then. -- nosy: +benjamin.peterson priority: release blocker - critical versions: +Python 3.1 -Python 3.0 ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Barry A. Warsaw [EMAIL PROTECTED] added the comment: Can you get this done before beta 3? ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Changes by Benjamin Peterson [EMAIL PROTECTED]: -- priority: critical - release blocker ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Barry A. Warsaw [EMAIL PROTECTED] added the comment: This didn't get done for the betas, but we're still going to release. Knocking it down to critical. -- nosy: +barry priority: release blocker - critical ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
Alexandre Vassalotti [EMAIL PROTECTED] added the comment: I will try to fix issue. I cannot promise that I will get it done before the beta though. -- nosy: +alexandre.vassalotti ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2919 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2919] Merge profile/cProfile in 3.0
New submission from Brett Cannon [EMAIL PROTECTED]: cProfile should go away in 3.0 (as a public module) and just be what profile uses when available. -- components: Library (Lib) messages: 67073 nosy: brett.cannon priority: release blocker severity: normal status: open title: Merge profile/cProfile in 3.0 type: behavior versions: Python 3.0 __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2919 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
