[issue29209] Remove old-deprecated ElementTree features

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

The rest will be removed in issue36543.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29209] Remove old-deprecated ElementTree features

[Jeroen Demeyer]

Jeroen Demeyer  added the comment:

This should be closed.

--
nosy: +jdemeyer

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29209] Remove old-deprecated ElementTree features

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 02ec92fa7b1dddc23d479ee0b87dc283793505a8 by Serhiy Storchaka in 
branch 'master':
bpo-29209: Remove old-deprecated features in ElementTree. (GH-6769)
https://github.com/python/cpython/commit/02ec92fa7b1dddc23d479ee0b87dc283793505a8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29209] Remove old-deprecated ElementTree features

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
versions: +Python 3.8 -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29209] Remove old-deprecated ElementTree features

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

The following two patches will remove getchildren() and getiterator() (in 3.9) 
and xml.etree.cElementTree (in an unspecified future).

--
Added file: 
https://bugs.python.org/file47584/etree_remove_deprecated_getiterator.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29209] Remove old-deprecated ElementTree features

[Serhiy Storchaka]

Change by Serhiy Storchaka :


Added file: 
https://bugs.python.org/file47585/etree_remove_deprecated_cElementTree.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29209] Remove old-deprecated ElementTree features

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

PR 6769 removes the html parameter and the doctype() method. getchildren() and 
getiterator() emit now a DeprecationWarning instead of 
PendingDeprecationWarning and will be removed in 3.9.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29209] Remove old-deprecated ElementTree features

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +6457

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29209] Remove old-deprecated ElementTree features

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

getchildren() and getiterator() have deprecation notes in their docstrings in 
lxml.etree.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29209] Remove old-deprecated ElementTree features

[Cheryl Sabella]

Cheryl Sabella  added the comment:

Serhiy,

Did you want to revive this for 3.8?

--
nosy: +csabella

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29209] Remove old-deprecated ElementTree features

[Stefan Behnel]

Stefan Behnel  added the comment:

Patch looks right to me.

I'd personally be ok with applying it to 3.7, but I'll leave the decision to 
you. Most of the removed "features" are non-controversial, except:

- "getchildren()" is probably still in use, also because it's more efficient 
than "list(elem)" in lxml (and has never been deprecated there), so code that 
supports both libraries might have preferred it

- cElementTree is probably still imported by quite a bit of code

So, this will have an impact on user code, despite any previous deprecation 
warnings. But it's easy to resolve in a backwards compatible way.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29209] Remove old-deprecated ElementTree features

[Gordon P. Hemsley]

Change by Gordon P. Hemsley :


--
nosy: +gphemsley

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29209] Remove old-deprecated ElementTree features

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
dependencies: +Add code deprecations in ElementTree

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29209] Remove old-deprecated ElementTree features

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

Proposed patch removes old-deprecated ElementTree features.

* Methods Element.getchildren(), Element.getiterator() and 
ElementTree.getiterator() deprecated in 2.7 and 3.2.
 Use list(elem) or iteration instead of getchildren(), methods iter() instead 
of getiterator(). 

* The html argument of XMLParser deprecated in 3.4.
 The rest of arguments are keyword-only now (passing them as keywords was 
recommended in the documentatin).

* The support of the doctype() method of XMLParser subclasses and its default 
implementation. Deprecated in 3.2. Define the doctype() method on a custom 
TreeBuilder target instead.

* The xml.etree.cElementTree module deprecated in 3.3.

Unfortunately some of these deprecations are in the documentation only or in 
Python implementatation, but not in C implementatation. Perhaps missed warnings 
should be added first (see issue29204). But if commit the patch from issue29204 
in 3.6, perhaps deprecated features could be removed in 3.7.

--
components: Extension Modules, Library (Lib), XML
files: etree_remove_deprecated.patch
keywords: patch
messages: 285000
nosy: eli.bendersky, ned.deily, scoder, serhiy.storchaka
priority: normal
severity: normal
stage: patch review
status: open
title: Remove old-deprecated ElementTree features
type: enhancement
versions: Python 3.7
Added file: http://bugs.python.org/file46216/etree_remove_deprecated.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com