[issue29326] Blank lines in ._pth file are not ignored

[Vladimir Chebotarev]

Change by Vladimir Chebotarev :


--
pull_requests: +13537
pull_request: https://github.com/python/cpython/pull/7243

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29326] Blank lines in ._pth file are not ignored

[Vladimir Chebotarev]

Change by Vladimir Chebotarev :


--
pull_requests:  -6869

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29326] Blank lines in ._pth file are not ignored

[R. David Murray]

R. David Murray  added the comment:

Vladimir, please open a new issue for this feature request.  This issue is 
closed.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29326] Blank lines in ._pth file are not ignored

[Malcolm Smith]

Malcolm Smith  added the comment:

FYI: I have created issue 33689 for the non-Windows-specific issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29326] Blank lines in ._pth file are not ignored

[Vladimir Chebotarev]

Vladimir Chebotarev  added the comment:

Hi Steve.

I'll try to explain what is my motivation.

I need a reliable way to run Python (not matter embedded or not) in isolated 
mode, but still having current directory in `sys.path` (empty entry).

Ironically I could misuse normal mode to simulate isolated mode with specified 
%PYTHONPATH% (which is not much handy, by the way), but hiding Windows Registry 
keys would look pretty hard (it is impossible to make a bat/cmd wrapper). 
Possibility to search %PYTHONPATH% in HKLM entries makes it even worse.

Empty entry in `sys.path` is a extremely popular thing, and many software 
depend on it. It looks like a bug that isolated mode cannot support such entry.

# How would I fix it.

Possibly we should allow another keyword for adding an empty entry (like we 
have an exclusion for `import site`).

Ideas are appreciated.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29326] Blank lines in ._pth file are not ignored

[Steve Dower]

Steve Dower  added the comment:

The python._pth file generated for the embeddable distribution includes ".", 
which allows you to import from the dist directory. The blank line should be 
ignored.

If you want to misuse the embeddable distribution by not restricting its search 
paths, delete the ._pth file.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29326] Blank lines in ._pth file are not ignored

[Vladimir Chebotarev]

Change by Vladimir Chebotarev :


--
pull_requests: +6869

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29326] Blank lines in ._pth file are not ignored

[Vladimir Chebotarev]

Vladimir Chebotarev  added the comment:

I shall attach pull request soon.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29326] Blank lines in ._pth file are not ignored

[Vladimir Chebotarev]

Vladimir Chebotarev  added the comment:

Hi.

I guess this issue has to be reopen because Alexey erroneously broke adding 
empty paths to `sys.path` along with his patch.

Official embeddable Pythons do contain a blank line in its ._pth, and this 
allowed users to import modules from script directory.

Kind regards,
Vladimir.

--
nosy: +excitoon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29326] Blank lines in ._pth file are not ignored

[Steve Dower]

Steve Dower  added the comment:

Please create a new issue. This one is closed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29326] Blank lines in ._pth file are not ignored

[Malcolm Smith]

Malcolm Smith  added the comment:

> I'm not aware of any such issue with .pth files - the underscore in ._pth is 
> deliberate.

An identical issue *does* exist for .pth files. As you can see from examining 
site.addpackage, it does not ignore blank lines as the documentation says. 
Ammar's patch should also be applied.

--
nosy: +Malcolm Smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29326] Blank lines in ._pth file are not ignored

[Ammar Askar]

Changes by Ammar Askar :


--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29326] Blank lines in ._pth file are not ignored

[Roundup Robot]

Roundup Robot added the comment:


New changeset 6d90b135e36c5b2794a29f650ebebf8bbd96f3fb by Steve Dower in branch 
'3.6':
Issue #29326: Ignores blank lines in ._pth files (Patch by Alexey Izbyshev)
https://github.com/python/cpython/commit/6d90b135e36c5b2794a29f650ebebf8bbd96f3fb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29326] Blank lines in ._pth file are not ignored

[Roundup Robot]

Roundup Robot added the comment:


New changeset 6d90b135e36c5b2794a29f650ebebf8bbd96f3fb by Steve Dower in branch 
'master':
Issue #29326: Ignores blank lines in ._pth files (Patch by Alexey Izbyshev)
https://github.com/python/cpython/commit/6d90b135e36c5b2794a29f650ebebf8bbd96f3fb

New changeset 3ba099c135cdbced6c2ff168a90a689a83b376db by Steve Dower in branch 
'master':
Issue #29326: Ignores blank lines in ._pth files (Patch by Alexey Izbyshev)
https://github.com/python/cpython/commit/3ba099c135cdbced6c2ff168a90a689a83b376db


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29326] Blank lines in ._pth file are not ignored

[Steve Dower]

Changes by Steve Dower :


--
assignee:  -> steve.dower
resolution:  -> fixed
stage: needs patch -> resolved

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29326] Blank lines in ._pth file are not ignored

[Roundup Robot]

Roundup Robot added the comment:

New changeset 54fea351e3f9 by Steve Dower in branch '3.6':
Issue #29326: Ignores blank lines in ._pth files (Patch by Alexey Izbyshev)
https://hg.python.org/cpython/rev/54fea351e3f9

New changeset a0ff777ab153 by Steve Dower in branch 'default':
Issue #29326: Ignores blank lines in ._pth files (Patch by Alexey Izbyshev)
https://hg.python.org/cpython/rev/a0ff777ab153

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29326] Blank lines in ._pth file are not ignored

[Steve Dower]

Steve Dower added the comment:

I haven't had a chance to try the patch (underpth_blank_lines.diff) or apply 
it, but it looks right.

If one of the other core devs gets to apply this before I do, feel free.

Alexey, you don't need to sign a CLA for this fix, but if you're going to 
contribute more then you may want to: 
https://docs.python.org/devguide/committing.html#contributor-licensing-agreements
 It's all online, and it'll help save the core developers from having to 
evaluate whether you need it or not (which I can do, because it comes up often 
for me in my day job, but not everyone has that experience). And thanks for 
this patch!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29326] Blank lines in ._pth file are not ignored

[Alexey Izbyshev]

Alexey Izbyshev added the comment:

I've encountered this issue too. (FYI, the official 3.6.0 embeddable zip from 
https://www.python.org/downloads/windows/ does contain a blank line in its 
._pth, so all its users get an invalid entry in sys.path).

The patch is attached. I couldn't fix tests in more straightforward way because 
both of them were broken:
* Both of them generated ._pth with 'import site'
* Both of them checked for zero exit code instead of non-zero one, but both 
passed because predicates in sys.exit() were incorrect

I've strengthened the check in 'nosite' test because it is trivial to fully 
emulate sys.path calculation logic in this case. I've preserved weaker checks 
in the other test because I didn't want to emulate site.py logic.

--
nosy: +izbyshev
Added file: http://bugs.python.org/file46433/underpth_blank_lines.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29326] Blank lines in ._pth file are not ignored

[Steve Dower]

Steve Dower added the comment:

The fix for this issue is needed in PC/getpathp.c as this is a special feature 
in path generation on Windows.

I'm not aware of any such issue with .pth files - the underscore in ._pth is 
deliberate.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29326] Blank lines in ._pth file are not ignored

[Ammar Askar]

Ammar Askar added the comment:

I've attached a patch that makes the site package ignore empty lines in .pth 
files. Along with a test for this behavior. I'm not really familiar with the 
site machinery so I hope the test and code are fine.

--
keywords: +patch
nosy: +ammar2
Added file: http://bugs.python.org/file46365/empty_path.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29326] Blank lines in ._pth file are not ignored

[Steve Dower]

New submission from Steve Dower:

If a python._pth file includes a blank line, it gets treated as '\n' which is 
then appended to the directory and used as an entry in sys.path.

Empty lines should be ignored completely.

--
components: Windows
messages: 285809
nosy: paul.moore, steve.dower, tim.golden, zach.ware
priority: low
severity: normal
stage: needs patch
status: open
title: Blank lines in ._pth file are not ignored
type: behavior
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com