[issue29474] Grammatical errors in weakref.WeakValueDictionary docs

[Zachary Ware]

Zachary Ware added the comment:


New changeset 5c329882fa20f615375f068176e569de7389fa3f by Zachary Ware 
(Mariatta) in branch '2.7':
bpo-29474: Improve documentation for weakref.WeakValueDictionary (#11)
https://github.com/python/cpython/commit/5c329882fa20f615375f068176e569de7389fa3f


--
nosy: +zach.ware

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29474] Grammatical errors in weakref.WeakValueDictionary docs

[Mariatta Wijaya]

Mariatta Wijaya added the comment:


New changeset ae828714ebdb7a0d69bf23c1f6d606e5e63bdcfe by Mariatta in branch 
'3.5':
bpo-29474: Improve documentation for weakref.WeakValueDictionary (#23)
https://github.com/python/cpython/commit/ae828714ebdb7a0d69bf23c1f6d606e5e63bdcfe


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29474] Grammatical errors in weakref.WeakValueDictionary docs

[Mariatta Wijaya]

Mariatta Wijaya added the comment:


New changeset 308f789d00735e6707dbc5c8f60a1c8cf245fb4b by Mariatta in branch 
'3.6':
bpo-29474: Improve documentation for weakref.WeakValueDictionary (#22)
https://github.com/python/cpython/commit/308f789d00735e6707dbc5c8f60a1c8cf245fb4b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29474] Grammatical errors in weakref.WeakValueDictionary docs

[Mariatta Wijaya]

Mariatta Wijaya added the comment:


New changeset 3110a379bbb1ec10a84d70a2f0faffcf8d22c7ed by Mariatta in branch 
'master':
bpo-29474: Improve documentation for weakref.WeakValueDictionary (#10)
https://github.com/python/cpython/commit/3110a379bbb1ec10a84d70a2f0faffcf8d22c7ed


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29474] Grammatical errors in weakref.WeakValueDictionary docs

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Thanks, everyone :)
The GitHub PRs have been merged.

Closing this issue.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29474] Grammatical errors in weakref.WeakValueDictionary docs

[Mariatta Wijaya]

Changes by Mariatta Wijaya :


--
pull_requests: +41

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29474] Grammatical errors in weakref.WeakValueDictionary docs

[Mariatta Wijaya]

Changes by Mariatta Wijaya :


--
pull_requests: +42

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29474] Grammatical errors in weakref.WeakValueDictionary docs

[Mariatta Wijaya]

Changes by Mariatta Wijaya :


--
pull_requests: +40

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29474] Grammatical errors in weakref.WeakValueDictionary docs

[Mariatta Wijaya]

Changes by Mariatta Wijaya :


--
pull_requests: +39

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29474] Grammatical errors in weakref.WeakValueDictionary docs

[Marco Buttu]

Marco Buttu added the comment:

Thanks Mariatta, now it is OK to me

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29474] Grammatical errors in weakref.WeakValueDictionary docs

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Thanks for reviewing, Marco :)
Updated the patch.

--
Added file: http://bugs.python.org/file46597/issue29474py3-2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29474] Grammatical errors in weakref.WeakValueDictionary docs

[Marco Buttu]

Marco Buttu added the comment:

The second patch LGTM. In the first one there is a typo (see review).

--
nosy: +marco.buttu

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29474] Grammatical errors in weakref.WeakValueDictionary docs

[Mariatta Wijaya]

Changes by Mariatta Wijaya :


--
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29474] Grammatical errors in weakref.WeakValueDictionary docs

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

And here is the patch that fixes the issue for python 2.7.

--
Added file: http://bugs.python.org/file46571/issue29474py2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29474] Grammatical errors in weakref.WeakValueDictionary docs

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Attached is the patch to fix the grammatical errors for versions 3.5+

--
keywords: +patch
Added file: http://bugs.python.org/file46570/issue29474py3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29474] Grammatical errors in weakref.WeakValueDictionary docs

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

You're right, Victor :)

The wording in 2.7 is a little bit different, but should be fixed too.

In 2.7:

These method have the same issues as the iterkeyrefs() and keyrefs() methods of 
WeakKeyDictionary objects.

Assigning this to myself.

--
assignee: docs@python -> Mariatta
nosy: +rhettinger
versions: +Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29474] Grammatical errors in weakref.WeakValueDictionary docs

[STINNER Victor]

STINNER Victor added the comment:

Would you mind to propose a patch? Thanks in advance.

Note: the sentence is also wrong in Python 2.7 doc, no?

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29474] Grammatical errors in weakref.WeakValueDictionary docs

[Mariatta Wijaya]

New submission from Mariatta Wijaya:

https://docs.python.org/3/library/weakref.html?highlight=weakref#weakref.WeakValueDictionary

There are grammatical errors in the sentence:

These method have the same issues as the and keyrefs() method of 
WeakKeyDictionary objects.

Reported by Arthur Goldberg in 
https://mail.python.org/pipermail/docs/2017-February/029957.html

--
assignee: docs@python
components: Documentation
keywords: easy
messages: 287241
nosy: Mariatta, docs@python
priority: normal
severity: normal
status: open
title: Grammatical errors in weakref.WeakValueDictionary docs
versions: Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com