[issue29706] IDLE needs syntax highlighting for async and await

[Terry J. Reedy]

Change by Terry J. Reedy :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29706] IDLE needs syntax highlighting for async and await

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset 1b0d65fa102fae087254009f6d9903b1d4257d78 by Terry Jan Reedy in 
branch '3.6':
[3.6] bpo-29706: IDLE now colors async and await as keywords in 3.6. (#6879)
https://github.com/python/cpython/commit/1b0d65fa102fae087254009f6d9903b1d4257d78


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29706] IDLE needs syntax highlighting for async and await

[Terry J. Reedy]

Change by Terry J. Reedy :


--
pull_requests: +6551

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29706] IDLE needs syntax highlighting for async and await

[miss-islington]

miss-islington  added the comment:


New changeset 7c59a33491b0bde639a9382ef1de2423207a8cc7 by Miss Islington (bot) 
in branch '3.6':
bpo-29706: Test that IDLE colors async/await as keywords. (GH-6846)
https://github.com/python/cpython/commit/7c59a33491b0bde639a9382ef1de2423207a8cc7


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29706] IDLE needs syntax highlighting for async and await

[miss-islington]

miss-islington  added the comment:


New changeset 8717cfeb6b8bebdfe13df0e9268ddd252ab5ecad by Miss Islington (bot) 
in branch '3.7':
bpo-29706: Test that IDLE colors async/await as keywords. (GH-6846)
https://github.com/python/cpython/commit/8717cfeb6b8bebdfe13df0e9268ddd252ab5ecad


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29706] IDLE needs syntax highlighting for async and await

[miss-islington]

Change by miss-islington :


--
pull_requests: +6542

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29706] IDLE needs syntax highlighting for async and await

[miss-islington]

Change by miss-islington :


--
pull_requests: +6541
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29706] IDLE needs syntax highlighting for async and await

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset 389a48ede92bf7965889d554d2cd17b50d6e3d86 by Terry Jan Reedy in 
branch 'master':
bpo-29706: Test that IDLE colors async/await as keywords. (GH-6846)
https://github.com/python/cpython/commit/389a48ede92bf7965889d554d2cd17b50d6e3d86


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29706] IDLE needs syntax highlighting for async and await

[Terry J. Reedy]

Terry J. Reedy  added the comment:

PR 6846 adds the htest line to all versions (no news).  When merged, I will 
augment the keyword list and add a news blurb for 3.6.

--
stage: patch review -> needs patch
versions:  -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29706] IDLE needs syntax highlighting for async and await

[Terry J. Reedy]

Change by Terry J. Reedy :


--
pull_requests: +6526
stage: test needed -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29706] IDLE needs syntax highlighting for async and await

[David E. Franco G.]

David E. Franco G. added the comment:

I found the problem, it was a test.pyc file that was in my personal folder... 
once deleted it work perfect

the build-in test module should have some other name...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29706] IDLE needs syntax highlighting for async and await

[Terry J. Reedy]

Terry J. Reedy added the comment:

If 'import test' fails that way, then there is a problem either with Anaconda 
or your installation.  You might try deleting 
.../Lib/test/__pycache__/__init__*.pyc.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29706] IDLE needs syntax highlighting for async and await

[David E. Franco G.]

David E. Franco G. added the comment:

Ok, Done.
that work in both 3.5 and 3.6 
I also did the 

python -m idlelib.ColorDelegator

and 

python -m idlelib.colorizer

and they turn ok

I also open those modules in their respective idle and run them, ColorDelegator 
work ok but colorizer throw me this error

Traceback (most recent call last):
  File "C:\Anaconda3\Lib\idlelib\colorizer.py", line 279, in 
verbosity=2, exit=False)
  File "C:\Anaconda3\lib\unittest\main.py", line 63, in __init__
self.module = __import__(module)
  File "C:\Anaconda3\lib\idlelib\idle_test\test_colorizer.py", line 8, in 

from test.support import requires
ImportError: bad magic number in 'test': b'\x03\xf3\r\n'
>>>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29706] IDLE needs syntax highlighting for async and await

[Terry J. Reedy]

Terry J. Reedy added the comment:

David, the easiest thing to do would be to copy and paste the following
 + ['async', 'await']
into this line of colorizer.py (ColorDelegator.py in 3.5)
kw = r"\b" + any("KEYWORD", keyword.kwlist) + r"\b"
about line 17, to get
kw = r"\b" + any("KEYWORD", keyword.kwlist + ['async', 'await']) + r"\b"

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29706] IDLE needs syntax highlighting for async and await

[David E. Franco G.]

David E. Franco G. added the comment:

>I presume you would like 'async' and 'await' highlighted as keywords.

Yes. 
Some others tools like IPython and the Spider IDE that come with the Anaconda 
package already highlighted them as keywords, even if you can use them as 
normal variables.

>The test is to run colorizer.py as main module (python -m >idlelib.colorize, 
>or F5 in IDLE editor).  Click 'Test' button and check >that 'async' and 
>'await' have same color as other keywords.  This >cannot affect anything in 
>test suite; colorizer is only used by >turtledemo, which is not tested, and 
>which will not notice anyway.

super, what I have to do to put the patch so I can test it?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29706] IDLE needs syntax highlighting for async and await

[Martin Panter]

Martin Panter added the comment:

See also Issue 26264 about the “keyword” module

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29706] IDLE needs syntax highlighting for async and await

[Terry J. Reedy]

Terry J. Reedy added the comment:

Always coloring 'async' and 'await' is trivial (augment expression and add test 
line) and acceptable to me.

I am a git neophyte and am waiting for workflow development to settle down 
before working on new setup for git.  If you want to submit the change for 
3.6.1, go ahead. (But leave issue open.)  Otherwise, I will get it into 3.6.2 
(and 3.7).  Patch is against 3.6 idlelib.colorize, but 3.7 is identical.

The test is to run colorizer.py as main module (python -m idlelib.colorize, or 
F5 in IDLE editor).  Click 'Test' button and check that 'async' and 'await' 
have same color as other keywords.  This cannot affect anything in test suite; 
colorizer is only used by turtledemo, which is not tested, and which will not 
notice anyway.

--
keywords: +patch
Added file: http://bugs.python.org/file46693/colorize_async.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29706] IDLE needs syntax highlighting for async and await

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
keywords: +easy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29706] IDLE needs syntax highlighting for async and await

[Terry J. Reedy]

Terry J. Reedy added the comment:

I presume you would like 'async' and 'await' highlighted as keywords.  However, 
IDLE takes its definition of 'keyword' from keyword.kwlist.  'Async' and 
'await' are currently not on that list as they are not yet keywords.

>>> async = 1
>>> await = 2

According to https://www.python.org/dev/peps/pep-0492/#transition-plan, the 
intention was (is?) to make them keywords in 3.7.  As of Feb 11, that had not 
happened yet.  If and when it does, this issue will be taken care of.

I may consider adding a special context sensitive case for 3.6, if the 
colorizer code makes it easily possible.  Care is needed since it would be a 
mistake to mark them as keywords in the above statements.

The difficulty is that colorizer uses regexes and a bit of context sensitive 
code, while python is using a full grammar parse.  I believe that either at the 
beginning of a line and 'async' followed by 'for' or 'with' or 'await' not 
followed by certain punctuation ('.', ',', or '=') should be treated as a 
keyword.

Yury, does the rule above look about right?  'Await' seems trickier than 
'async'.

I think it may be possible to add regexes that are not literal words to the 
kwlist.  If so, adding 'async +def ', 'async +for ', 'async +with ', and 'await 
+[^.,=]' and not worrying about 'beginning or line' or tabs  (instead of 
spaces) between would be easy and probably good enough.

--
nosy: +yselivanov
stage:  -> test needed
type: behavior -> enhancement
versions: +Python 3.7 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29706] IDLE needs syntax highlighting for async and await

[Yury Selivanov]

Yury Selivanov added the comment:

>According to https://www.python.org/dev/peps/pep-0492/#transition-plan, the 
>intention was (is?) to make them keywords in 3.7.  As of Feb 11, that had not 
>happened yet.  If and when it does, this issue will be taken care of.

I plan to do that in the next couple of weeks.

> I may consider adding a special context sensitive case for 3.6, if the 
> colorizer code makes it easily possible.  Care is needed since it would be a 
> mistake to mark them as keywords in the above statements.

If possible I would make 'async' and 'await' to be always highlighted. Even if 
a user writes <3.7 code and uses 'async' as a variable, it would still be great 
to let the user know that there is something wrong with this variable.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29706] IDLE needs syntax highlighting for async and await

[David E. Franco G.]

New submission from David E. Franco G.:

Well, this is pretty self explanatory, when playing with this new features of 
async and await (https://docs.python.org/3.5/whatsnew/3.5.html#new-features) I 
found to me surprise that there is no syntax highlighting for it in the IDLE 
for py3.5 and also for py3.6

So I humbly ask for its addition. Thanks

--
assignee: terry.reedy
components: IDLE
files: no syntax highlighting.png
messages: 288849
nosy: David E. Franco G., terry.reedy
priority: normal
severity: normal
status: open
title: IDLE needs syntax highlighting for async and await
type: behavior
versions: Python 3.5, Python 3.6
Added file: http://bugs.python.org/file46692/no syntax highlighting.png

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com