[issue30068] missing iter(self) in _io._IOBase.readlines

[Xiang Zhang]

Xiang Zhang added the comment:


New changeset 4f43f87b6246e13e0eefc793a2c5415c915723c3 by Xiang Zhang in branch 
'3.5':
bpo-30068: add missing iter(self) in _io._IOBase.readlines when hint is present 
(#1130) (#1151)
https://github.com/python/cpython/commit/4f43f87b6246e13e0eefc793a2c5415c915723c3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30068] missing iter(self) in _io._IOBase.readlines

[Xiang Zhang]

Changes by Xiang Zhang :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30068] missing iter(self) in _io._IOBase.readlines

[Xiang Zhang]

Xiang Zhang added the comment:


New changeset d5fa5f3ce7d9003bbd3975d1bf634043305ae18f by Xiang Zhang in branch 
'3.6':
bpo-30068: add missing iter(self) in _io._IOBase.readlines when hint is present 
(#1130) (#1150)
https://github.com/python/cpython/commit/d5fa5f3ce7d9003bbd3975d1bf634043305ae18f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30068] missing iter(self) in _io._IOBase.readlines

[Xiang Zhang]

Xiang Zhang added the comment:


New changeset 5fbdfc36f397ad46f4057d527855dfacb77242ce by Xiang Zhang in branch 
'2.7':
bpo-30068: add missing iter(self) in _io._IOBase.readlines when hint is present 
(#1152)
https://github.com/python/cpython/commit/5fbdfc36f397ad46f4057d527855dfacb77242ce


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30068] missing iter(self) in _io._IOBase.readlines

[Xiang Zhang]

Changes by Xiang Zhang :


--
pull_requests: +1283

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30068] missing iter(self) in _io._IOBase.readlines

[Xiang Zhang]

Changes by Xiang Zhang :


--
pull_requests: +1282

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30068] missing iter(self) in _io._IOBase.readlines

[Xiang Zhang]

Changes by Xiang Zhang :


--
pull_requests: +1281

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30068] missing iter(self) in _io._IOBase.readlines

[Xiang Zhang]

Xiang Zhang added the comment:


New changeset 026435ce49419a3366171416c68114dd8a1144c7 by Xiang Zhang in branch 
'master':
bpo-30068: add missing iter(self) in _io._IOBase.readlines when hint is present 
(#1130)
https://github.com/python/cpython/commit/026435ce49419a3366171416c68114dd8a1144c7


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30068] missing iter(self) in _io._IOBase.readlines

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
nosy: +benjamin.peterson, serhiy.storchaka, stutzbach

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30068] missing iter(self) in _io._IOBase.readlines

[Xiang Zhang]

Changes by Xiang Zhang :


--
pull_requests: +1264

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30068] missing iter(self) in _io._IOBase.readlines

[Xiang Zhang]

New submission from Xiang Zhang:

In _io._IOBase.readlines, it straightly uses PyIter_Next(self). But 
iter(_io._IOBase) does more work than just returning itself.

>>> import _io
>>> f = _io._IOBase()
>>> f.close()
>>> f.readlines()
Traceback (most recent call last):
  File "", line 1, in 
ValueError: I/O operation on closed file.
>>> f.readlines(10)
Traceback (most recent call last):
  File "", line 1, in 
AttributeError: '_io._IOBase' object has no attribute 'read'

--
components: IO
messages: 291641
nosy: xiang.zhang
priority: normal
severity: normal
stage: patch review
status: open
title: missing iter(self) in _io._IOBase.readlines
type: behavior
versions: Python 2.7, Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com