[issue30174] Duplicate code in pickletools.py

2017-04-27 Thread Serhiy Storchaka 

Serhiy Storchaka added the comment:

Thank you for catching this Jelle!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30174] Duplicate code in pickletools.py

2017-04-27 Thread Serhiy Storchaka 

Serhiy Storchaka added the comment:


New changeset 5a4e3d8f9c37e700402b23fafbfc413e5ca3113d by Serhiy Storchaka 
(Jelle Zijlstra) in branch 'master':
bpo-30174: Remove duplicate definition from pickletools (#1301)
https://github.com/python/cpython/commit/5a4e3d8f9c37e700402b23fafbfc413e5ca3113d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30174] Duplicate code in pickletools.py

2017-04-26 Thread Serhiy Storchaka 

Serhiy Storchaka added the comment:

The variant without " in the string" is more correct and consistent with bytes4 
and bytes8.

The first bytes1 was added in issue16550. The duplicate was mistakenly added in 
issue17810.

This change can be backported, but it is not worth since the duplication 
doesn't have any effect.

--
components: +Library (Lib)
nosy: +pitrou, serhiy.storchaka
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30174] Duplicate code in pickletools.py

2017-04-26 Thread Mariatta Wijaya 

Mariatta Wijaya added the comment:

Does this need to be backported?

--
nosy: +Mariatta
stage:  -> patch review
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30174] Duplicate code in pickletools.py

2017-04-26 Thread Tim Peters 

Tim Peters added the comment:

I already commented on github - +1 for this change.

--
nosy: +tim.peters

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30174] Duplicate code in pickletools.py

2017-04-26 Thread Jelle Zijlstra 

New submission from Jelle Zijlstra:

The bytes1 ArgumentDescriptor is duplicated in pickletools.py.

--
messages: 292364
nosy: Jelle Zijlstra, alexandre.vassalotti
priority: normal
pull_requests: 1408
severity: normal
status: open
title: Duplicate code in pickletools.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com