[issue30222] make_zip.py had a bug when setting up full 64 bit distribution.

[Steve Dower]

Changes by Steve Dower :


--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30222] make_zip.py had a bug when setting up full 64 bit distribution.

[Segev Finer]

Segev Finer added the comment:

Since PR 2750 is merged, I think this can be closed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30222] make_zip.py had a bug when setting up full 64 bit distribution.

[Steve Dower]

Steve Dower added the comment:

That's the PR I meant (on phone today, so navigating gh is out). If you look 
through history you'll see it's mostly a revert of a revert, at least for that 
script.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30222] make_zip.py had a bug when setting up full 64 bit distribution.

[Segev Finer]

Segev Finer added the comment:

I did make a PR which only changes -a/--arch to a choices argument. 
https://github.com/python/cpython/pull/2808

I guess the PR you are talking about is 
https://github.com/python/cpython/pull/2750/files which changes this entirely.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30222] make_zip.py had a bug when setting up full 64 bit distribution.

[Steve Dower]

Steve Dower added the comment:

I have a separate PR out that fixes this one, just waiting on Zach to review 
(but since it only touches the more obscure release files, it's rare for anyone 
but me to have an opinion). 

The script is supposed to take the build path rather than the architecture, but 
that got reverted at some point.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30222] make_zip.py had a bug when setting up full 64 bit distribution.

[Segev Finer]

Changes by Segev Finer :


--
pull_requests: +2859

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30222] make_zip.py had a bug when setting up full 64 bit distribution.

[Segev Finer]

Segev Finer added the comment:

Try with:

.\python.bat Tools\msi\make_zip.py -a amd64 -o py37-amd64.zip

It requires amd64 instead of x64. Probably can add a choices 
(https://docs.python.org/3/library/argparse.html#choices) argument there to 
make it more robust.

--
nosy: +Segev Finer

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30222] make_zip.py had a bug when setting up full 64 bit distribution.

[Decorater]

New submission from Decorater:

Basically running make_zip like this:

".\PCbuild\amd64\python.exe" ".\Tools\msi\make_zip.py" -a x64 -o 
".\python36-x86-x64"

Cuases make_zip mess up where none of the libs\*.lib, nor any of the assemblies 
are copied. And is reproducible on me.

However doing something like this on the 32 bit version of python does not get 
this issue.

--
components: Demos and Tools, Windows
messages: 292694
nosy: Decorater, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: make_zip.py had a bug when setting up full 64 bit distribution.
versions: Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com