[issue30304] TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Thanks!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30304] TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7

[Mariatta Wijaya]

Mariatta Wijaya added the comment:


New changeset 0666d0e50432e3b0109db96b8e48fb6c496bd49c by Mariatta (Aditya 
Hase) in branch '2.7':
bpo-30304: Improve TestCase.assertMultiLineEqual docs (GH-2847)
https://github.com/python/cpython/commit/0666d0e50432e3b0109db96b8e48fb6c496bd49c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30304] TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
versions:  -Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30304] TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7

[Aditya Hase]

Aditya Hase added the comment:

I've fixed that.

--
versions: +Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30304] TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7

[Aditya Hase]

Changes by Aditya Hase :


--
pull_requests: +2893

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30304] TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Thanks Serhiy.

Aditya, your PR was made against the master branch. Can you make the change 
against the 2.7 branch?

Thanks.

--
nosy: +Mariatta

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30304] TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

This is related only to 2.7. All correct in 3.x.

--
nosy: +serhiy.storchaka
versions:  -Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30304] TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7

[Mariatta Wijaya]

Changes by Mariatta Wijaya :


--
stage: needs patch -> patch review
versions: +Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30304] TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7

[Aditya Hase]

Aditya Hase added the comment:

Hi, I'm new to python development community.
I've created a GitHub PR that fixes this issue.

--
nosy: +adityahase

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30304] TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7

[Aditya Hase]

Changes by Aditya Hase :


--
pull_requests: +2891

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30304] TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7

[Martin Panter]

Martin Panter added the comment:

I think the simplest way forward would be to add the word “Unicode” back in. 
You could look at making a Git Hub pull request for this if you want. Hopefully 
somebody else can merge it though, because I probably won’t be in a position to 
do so for a while.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30304] TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7

[Sourav Singh]

Sourav Singh added the comment:

@Martin I would like to take a stab at the issue. How do I start?

--
nosy: +Sourav Singh

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30304] TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7

[Martin Panter]

New submission from Martin Panter:

In Mercurial revision 6e5b5d1b6714, the documentation for 
“assertMultiLineEqual” was changed from

This method is used by default when comparing Unicode strings with 
“assertEqual”.

to

This method is used by default when comparing strings with “assertEqual”. 

The new text is misleading because “str” objects are also strings, but the 
default does not apply to “str” objects.

--
assignee: docs@python
components: Documentation, Tests
keywords: easy
messages: 293229
nosy: docs@python, ezio.melotti, martin.panter
priority: normal
severity: normal
stage: needs patch
status: open
title: TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7
type: behavior
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com