[issue30629] lower() is called twice

[Terry J. Reedy]

Terry J. Reedy added the comment:

What persuaded me to make the offer was your extra effort to include the link 
to the specific line and the minimal quote needed to explain.  The link made it 
trivial to look at the context of the change.

--
assignee:  -> terry.reedy
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30629] lower() is called twice

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 5cc7ac24da10568d2a910a91a24183b904118cf8 by terryjreedy (Motoki 
Naruse) in branch 'master':
bpo-30629: Add Motoki Naruse to Misc/ACKS (#2284)
https://github.com/python/cpython/commit/5cc7ac24da10568d2a910a91a24183b904118cf8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30629] lower() is called twice

[成瀬基樹]

Changes by 成瀬基樹 :


--
pull_requests: +2332

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30629] lower() is called twice

[成瀬基樹]

成瀬基樹 added the comment:

It will be highlight of my programmer life. Thank you. That pull request is 
just the beginning, not the last.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30629] lower() is called twice

[Terry J. Reedy]

Terry J. Reedy added the comment:

This appears to be your first CPython contribution.  Welcome.  We hope it is 
not the last.  If you prepare a PR to add yourself to Misc/ACKS, in appropriate 
alphabetical position, I will merge it.  Just suggest me as a reviewer.

--
resolution:  -> fixed
stage:  -> resolved
type:  -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30629] lower() is called twice

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 3358d589fb51372a56ddcfffa277855e5661c4c0 by terryjreedy (Motoki 
Naruse) in branch 'master':
bpo-30629: Remove second call of str.lower() in html.parser.parse_endtag. 
(#2099)
https://github.com/python/cpython/commit/3358d589fb51372a56ddcfffa277855e5661c4c0


--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30629] lower() is called twice

[Roundup Robot]

Changes by Roundup Robot :


--
pull_requests: +2155

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30629] lower() is called twice

[成瀬基樹]

New submission from 成瀬基樹:

https://github.com/python/cpython/blob/master/Lib/html/parser.py#L415

elem is already lowercase string but call lower() for handle_endtag().

elem = match.group(1).lower() # script or style
if self.cdata_elem is not None:
if elem != self.cdata_elem:
self.handle_data(rawdata[i:gtpos])
return gtpos

self.handle_endtag(elem.lower())

--
components: Library (Lib)
messages: 295689
nosy: Motoki
priority: normal
severity: normal
status: open
title: lower() is called twice
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com